Update snapshot class for matching eip712 specs and data structured - #1006
Draft
petrovska-petro wants to merge 5 commits into
Draft
Update snapshot class for matching eip712 specs and data structured#1006petrovska-petro wants to merge 5 commits into
petrovska-petro wants to merge 5 commits into
Conversation
petrovska-petro
marked this pull request as draft
December 7, 2022 14:19
gosuto-inzasheru
changed the title
Collaborator
|
discussed with @petrovska-petro; will be easier to help debug and review with a test case in |
petrovska-petro
marked this pull request as ready for review
January 10, 2023 14:39
Collaborator
Author
push test in 6e80c8d run: |
petrovska-petro
marked this pull request as draft
January 10, 2023 14:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tackles #986
NOTE: hashes generation does not match between the class and the relayer endpoint