Pin the read count on both autoRead paths - #2304
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
#2302 stopped AsyncHttpClientHandler requesting a read that Netty's HeadContext already drives when autoRead is on.
Nothing in the suite catches that duplicate coming back, since the connection works correctly either way
Modification:
Add AsyncHttpClientHandlerReadTest, an EmbeddedChannel test that counts reads at an outbound handler placed in front of the handler under test, so it sees both entry points.
Covers channelActive and channelReadComplete with autoRead on, and channelReadComplete with it off.
Result:
One read per cycle with autoRead on, reads still driven with it off; without #2302 the count is 2.