Add DREAMS - #277
Conversation
teutoburg
added
instrument-specific
|
It looks like this branch was rebased anyway, so might as well have squashed all those "Update README.md" commits together to make this a bit cleaner, but then again I classify this whole thing as "whatever", so feel free to ignore. Oh and my "👍" was more of a "agree to do this instead of the other one", I'll only look at the actual changes once review is requested, as usual... |
|
I found it important to keep @Astrogirlanajli 's work represented in the commits. It was kinda a non-trivial exercise to rebase from one repository into a subdirectory of another repository, but it worked. Maybe we can still squash some of the commits, but that's for later. I'm going through the |
|
@hugobuddel good to see there's movement again here! Did you try squashing some of this (e.g. via a Oh and the other one (#273) is still open, even though you commented "closing". Is that intentional? |
|
I just rebased it now, first going to get it properly working |
Cleanup fields.py and remove output
Remove now unnecessary references to specific path Replace surfaces_table.throughput with system_transmission Remove FOV-workaround that is now not necessary anymore. Fixed by AstarVienna/ScopeSim#433. Rename testt.py to cluster.py and cleanup
|
I think DREAMS is good enough for now. There are some notebooks that do something useful, and some unfinished ones, but I prefer to have them in the repository so we can iteratively improve upon them. @teutoburg can you have a look whether this makes sense? No hurry. @Astrogirlanajli does this make sense to you too? |
Yes, it makes sense. |
|
I've added a Supernova notebook by @Astrogirlanajli and it looks awesome. This P.R. is fine as far as I'm concerned. Can you review @teutoburg ? No rush, with SPIE and all. |
3 participants
Add support for the wide-field imager DREAMS. Replaces #273.
Needs a bit more work