Skip to content

AtmoLibraryTERCurve works with parameters other than pwv - #972

Open
oczoske wants to merge 1 commit into
mainfrom
oc/mcd_calibration
Open

AtmoLibraryTERCurve works with parameters other than pwv#972
oczoske wants to merge 1 commit into
mainfrom
oc/mcd_calibration

Conversation

@oczoske

@oczoske oczoske commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

AtmoLibraryTERCurve is generalised to work with libraries categorised by parameters other than 'pwv'.

Needs AstarVienna/irdb/pull/365

@oczoske
oczoske requested a review from teutoburg August 13, 2026 16:31
@oczoske oczoske self-assigned this Aug 13, 2026
@oczoske oczoske added enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) API How users interact with the software labels Aug 13, 2026
@oczoske oczoske added the effects Related to a ScopeSim effect label Aug 13, 2026
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.89%. Comparing base (608adfa) to head (2d73d5e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   75.89%   75.89%           
=======================================
  Files          70       70           
  Lines        9030     9032    +2     
=======================================
+ Hits         6853     6855    +2     
  Misses       2177     2177           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg moved this to 👀 Awaiting Review in ScopeSim-development Aug 13, 2026

@teutoburg teutoburg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work if more than one parameter is provided? e.g.

kwargs:
  parameter: relH  # the quotes should be redundant here
  pmv: 25.
  relH: 25

I assume the pmv is ignored in this case? I'm note sure about that parameter, but I also don't have the mental capacity right now to come up with any alternative, so go ahead.

@oczoske

oczoske commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

Yes, pmv is ignored in this case. The effect was originally written for METIS Leiden sky, where the parameter was pwv. Out of laziness, that was hard-coded. Now we have a new set for MICADO, where the parameter is relH (humidity), so the effect needs to be flexible enough to accept that. The effect can only handle a single parameter at the moment. If we ever get a library that depends on two or more parameters then parameter will probably have to be a list. In any case, the setup must match what is in the FITS table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API How users interact with the software effects Related to a ScopeSim effect enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label)

Projects

Status: 👀 Awaiting Review

Development

Successfully merging this pull request may close these issues.

2 participants