Skip to content

Fix html5test execution - #126

Merged
FlorianRappl merged 2 commits into
AngleSharp:develfrom
lahma:pagetests
Jul 27, 2026
Merged

Fix html5test execution#126
FlorianRappl merged 2 commits into
AngleSharp:develfrom
lahma:pagetests

Conversation

@lahma

@lahma lahma commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • surface uncaught event-loop errors through the browsing context and fix XHR relative URL and terminal-error handling
  • add a deterministic, embedded HTML5test regression fixture and restore the live check as an explicit test
  • track the Jint eval destructuring failure in eval with var destructuring leaks InvalidCastException sebastienros/jint#2825; the live test reports that specific upstream blocker as inconclusive

Testing

  • dotnet test src/AngleSharp.Js.Tests/AngleSharp.Js.Tests.csproj -f net8.0
  • dotnet test src/AngleSharp.Js.Tests/AngleSharp.Js.Tests.csproj -f net462
  • dotnet test src/AngleSharp.Js.Tests/AngleSharp.Js.Tests.csproj -f net472
  • dotnet build src/AngleSharp.Js.sln

@FlorianRappl FlorianRappl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lahma
lahma marked this pull request as ready for review July 27, 2026 08:55
@FlorianRappl FlorianRappl added this to the v1.0 milestone Jul 27, 2026
@FlorianRappl
FlorianRappl merged commit 3bc8d97 into AngleSharp:devel Jul 27, 2026
5 checks passed
@lahma
lahma deleted the pagetests branch July 27, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants