Add separate TCP dial address for ClickHouse connections - #160
Merged
Conversation
BorisTyshkevich
marked this pull request as ready for review
August 5, 2026 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clickhouse.connect_hostconfiguration through YAML, JSON, CLI, andCLICKHOUSE_CONNECT_HOSTclickhouse.hostas the logical HTTP and TLS identity while overriding only the underlying TCP destinationWhy
Some deployments must bypass DNS or connect through a fixed internal address without changing the logical ClickHouse hostname. Using the IP as
clickhouse.hostbreaks HTTP routing, TLS SNI, and certificate hostname verification. This change separates those concerns while preserving existing behavior when the override is unset.Closes #159.
Validation
go test -short ./...go test -race ./pkg/config ./pkg/clickhouse ./pkg/server -shortgo test ./pkg/clickhouse -run '^TestConnectHostPlainProtocols$' -count=1 -vgit diff --checkThe integration test connects successfully to real embedded ClickHouse listeners over both HTTP and native TCP using an intentionally non-resolvable logical hostname and a reachable
connect_host.