fix(lib): correctness bugs, align with basic-js, refresh tooling & docs - #38
Merged
Merged
Conversation
- optional-test-extension.js: remove leftover `console.log('ERROR', err)`
debug line; return the test callback's promise so async failures are
awaited by node:test
- errors.js: mark pending tasks with `this.todo()` instead of `this.skip()`
(matches basic-js); NotImplementedError now respects its message argument
- lib/index.js: export NotImplementedError so stubs can import from ../lib
- src/*: import NotImplementedError from ../lib (was ../lib/errors) for
consistency with basic-js
- package.json: drop bogus `main: index.js`
- remove stale package-lock.json (pinned mocha/chai/sinon; repo has no deps
since the native-runner migration)
- README: drop obsolete node-gyp troubleshooting, bump recommended Node 16 -> 22
- add .nvmrc, .editorconfig and a CI workflow running `npm test`
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Cleanup of
lib/correctness bugs, alignment with thebasic-jsrepo, and removal of stale artifacts. No task logic or test expectations changed —npm teststays green on the stubs (0 fail, 20 todo).Bug fixes
lib/optional-test-extension.js— removed a leftoverconsole.log('ERROR', err)debug line that printed on every test error; the async path now returns its promise so failures are awaited bynode:test.lib/errors.js— pending tasks are marked withthis.todo()instead ofthis.skip()(matchesbasic-js);NotImplementedErrornow respects itsmessageargument.Consistency with basic-js
lib/index.js— exportNotImplementedError.src/*— importNotImplementedErrorfrom../lib(was../lib/errors).Housekeeping
package.json— dropped the bogusmain: index.js.package-lock.json(pinned ~100 mocha/chai/sinon packages from before the native-runner migration; the repo has no dependencies now).README.md— dropped the obsoletenode-gyptroubleshooting note and bumped the recommended Node version 16 → 22 (matchesengines)..nvmrc(22),.editorconfig, and a CI workflow runningnpm test.🤖 Generated with Claude Code