fix(scripts): tear down vite when the desktop dev window closes - #38
Merged
Merged
Conversation
…closes concurrently was started without -k, so the two children were independent: closing the Electron window ended only Electron, and vite kept listening on 5173 until the terminal itself was closed. The next `npm run dev:desktop` then failed with "Port 5173 is already in use" against a server the user had no idea was still up. The thumbs script already passes -k for the same reason. Match it here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
rosspeili
force-pushed
the
fix/dev-desktop-teardown
branch
from
August 7, 2026 11:02
d79c370 to
b746f27
Compare
Contributor
|
Thanks @AUDOSt0ck1ng, confirmed this is a real bug, and the fix is clean and tiny ( Added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37.
dev:desktopranconcurrentlywithout-k, so vite and Electron wereindependent children. Closing the AVATAR window ended only Electron and left
vite listening on 5173, which then blocked the next
npm run dev:desktopwithPort 5173 is already in use— against a server the developer had no reason tothink was still running.
The neighbouring
thumbsscript already passes-k, so this was an oversightrather than a deliberate difference. One flag, matching that precedent.
Verification
Both teardown directions, confirmed with
netstatshowing 5173 released and noleftover processes:
Scope
Developer-facing only.
dist:winand the packaged app do not use this script,and no runtime behaviour changes.
🤖 Generated with Claude Code