Prevent invalid quick calculations and clarify calculation history - #172
Merged
Conversation
kirillt
reviewed
Aug 13, 2026
| val isValid = | ||
| from != null && | ||
| currencies.size > 1 && | ||
| from.value.toDoubleArk() != 0.0 |
Member
There was a problem hiding this comment.
Maybe return Option from toDoubleArk()?
Collaborator
Author
There was a problem hiding this comment.
toDoubleArk() is a utility extension for converting a String to a number with tolerant parsing. This use case only needs a boolean validation result and treats an invalid value the same as zero, so returning Option would add unnecessary complexity here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
ValidateQuickCalculationUseCaseas the shared source of validationadd_quick_invalid_calculation_attemptwhen an invalid save is attemptedCalculation historyCleanupInvalidQuickCalculationsUseCaseto remove previously saved invalid calculations when the Quick screen opensquick_invalid_calculation_removedfor each invalid calculation removed