Load Arrow mapper libraries on registry lookup - #999
Open
arnavdham wants to merge 3 commits into
Open
Conversation
veprbl
reviewed
Aug 6, 2026
Comment on lines
+24
to
+25
| * Registration is expected to happen during shared library loading/startup, | ||
| * before worker threads query the registry. After registration the registry is |
Contributor
There was a problem hiding this comment.
A bit misleading, the loading happens lazily on getConverter/getReader calls, so users must not use those in multi-threaded context.
Contributor
Author
There was a problem hiding this comment.
But this initialization is thread safe. Once lazy loading is complete MT is completely fine.
Contributor
There was a problem hiding this comment.
Right, so it does matter when lazy loading happens. Races can occur if several threads start up and simultaneously try to initialize reader.
|
|
||
| for (auto& lib : fs::directory_iterator(dir)) { | ||
| const auto filename = lib.path().filename().string(); | ||
| if (filename.find("Arrow") != std::string::npos && filename.find("libarrow") == std::string::npos) { |
Contributor
There was a problem hiding this comment.
Why can it be either one? libarrow must come from arrow-cpp, which libpodioArrow is meant to link against, so it gets loaded as a dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Arrow mapper registration follow the same runtime-loading model as SIO.
The generated
*Arrowlibraries register Arrow types and converters through static initialization. This changes the Arrow type registry lookup to trigger the Arrow converter library loader, ensuring generated Arrow mapper libraries are loaded viadlopen()before registry lookupsBEGINRELEASENOTES
ENDRELEASENOTES