Skip to content

Return data on async getter (include) for hasMany - #407

Open
absynce wants to merge 3 commits into
1602:masterfrom
absynce:master
Open

Return data on async getter (include) for hasMany#407
absynce wants to merge 3 commits into
1602:masterfrom
absynce:master

Conversation

@absynce

@absynce absynce commented Jun 27, 2014

Copy link
Copy Markdown
Contributor

I added behavior to return data on async getter (include) for hasMany, e.g. user.posts(c) returns Array, to be consistent with belongsTo behavior.

User.all({ include: 'posts' }, function (err, users) { 
   var userPosts = users[0].posts(function () { }); // Returns Array of posts for users[0].
});

@1602 where should I test this? I initially thought scope.test.js since it's a change in that file but include.test.js looks like it is closer in setup. Although it doesn't appear to test public API behavior.

@1602

1602 commented Jun 28, 2014

Copy link
Copy Markdown
Owner

@absynce i think include.test.js is the right place because this scope method relies on include clause. Don't worry about existing tests, just organize them in natural way (you may want to add another tests section for that feature)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants