chore: upgrade to Rng 0.10 - #284
Merged
Merged
Conversation
juan518munoz
requested review from
SantiagoPittella,
TomasArrachea and
igamigo
August 13, 2026 18:43
| repository = "https://github.com/0xMiden/faucet" | ||
| rust-version = "1.93" | ||
| version = "0.16.0-alpha.1" | ||
| rust-version = "1.96.1" |
Collaborator
There was a problem hiding this comment.
is the patch version really needed? lets remove it otherwise
| rust-version = "1.93" | ||
| version = "0.16.0-alpha.1" | ||
| rust-version = "1.96.1" | ||
| version = "0.16.0-alpha.2" |
Collaborator
There was a problem hiding this comment.
should we switch to -rc.1?
Aligns the faucet with miden-client 0.16.0-rc.1, which is already on rand 0.10. rand 0.10 split the Rng trait: Rng is now the rand_core trait and random(), random_range() and fill() moved to a new RngExt, blanket-implemented for all Rng. Call sites switch from rand::Rng to rand::RngExt. Also drops the direct rand_chacha dependency. rand 0.10 replaced its rand_chacha dep with chacha20 and re-exports ChaCha20Rng behind its own chacha feature, so enabling that feature and using rand::rngs::ChaCha20Rng removes a duplicate ChaCha implementation from our dependency list.
Every locked miden-* crate (miden-protocol, miden-standards, miden-testing, miden-core and friends) declares rust-version 1.96.1, so the workspace's 1.93 under-declared the real MSRV. A build on rustc older than 1.96.1 would hit a resolver error rather than the clear MSRV message. The Dockerfile already pins rust:1.96-bookworm, a floating tag that resolves to the newest 1.96.x, so it needs no change.
juan518munoz
force-pushed
the
jmunoz-update-miden-deps
branch
from
August 18, 2026 15:57
fb71abe to
fd2e0f1
Compare
juan518munoz
changed the title
ricomateo
approved these changes
Aug 18, 2026
igamigo
approved these changes
Aug 18, 2026
Comment on lines
+12
to
+13
| - Updated `rand` to v0.10 and removed the direct `rand_chacha` dependency ([#284](https://github.com/0xMiden/faucet/pull/284)). | ||
| - Raised the declared `rust-version` to 1.96.1 to match the locked Miden dependencies ([#284](https://github.com/0xMiden/faucet/pull/284)). |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Updated `rand` to v0.10 and removed the direct `rand_chacha` dependency ([#284](https://github.com/0xMiden/faucet/pull/284)). | |
| - Raised the declared `rust-version` to 1.96.1 to match the locked Miden dependencies ([#284](https://github.com/0xMiden/faucet/pull/284)). | |
| - Updated `rand` to v0.10 and removed the direct `rand_chacha` dependency and updated the declared `rust-version` to `1.96.1`([#284](https://github.com/0xMiden/faucet/pull/284)). |
igamigo
changed the title
Rng 0.10
SantiagoPittella
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly superseeded by #285
Only relevant changes that remain applicable:
0.9to0.10, aligning with miden-client.RngforRngExtand drop directrand_chacha, both forced by rand0.10.