Skip to content

Inspector: stitch-length InputNumber should coalesce undo per edit #68

Description

@Eiluviann

From the independent review of PR #54. The stitch Length control became an InputNumber whose onChange calls updateSelection (which pushHistorys) on every keystroke (src/views/EditorView.tsx), so typing "45" can create separate undo entries for intermediate values. The previous Slider coalesced into one entry.

Acceptance

  • Editing the length produces a single undo entry per committed change (e.g. commit on onBlur/onPressEnter/onStep, or reuse the existing live-update coalescing path liveUpdateSelection/endLive in src/core/store.ts).

Severity: minor undo-granularity nit. (Note: this also gives liveUpdateSelection/endLive an in-app caller again — they're currently exercised only by tests.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions