refactor: 코딩 컨벤션 리팩터링

Author: whqtker

src/main/java/com/example/solidconnection/admin/university/controller/AdminUnivApplyInfoController.java

@@ -12,9 +12,9 @@
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.DeleteMapping;
 import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PatchMapping;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.PostMapping;
-import org.springframework.web.bind.annotation.PatchMapping;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;
@@ -47,15 +47,15 @@ public ResponseEntity<AdminUnivApplyInfoResponse> createUnivApplyInfo(
 
     @PatchMapping("/{id}")
     public ResponseEntity<AdminUnivApplyInfoResponse> updateUnivApplyInfo(
-            @PathVariable Long id,
+            @PathVariable long id,
             @Valid @RequestBody AdminUnivApplyInfoUpdateRequest request
     ) {
         return ResponseEntity.ok(adminUnivApplyInfoService.updateUnivApplyInfo(id, request));
     }
 
     @DeleteMapping("/{id}")
     public ResponseEntity<Void> deleteUnivApplyInfo(
-            @PathVariable Long id
+            @PathVariable long id
     ) {
         adminUnivApplyInfoService.deleteUnivApplyInfo(id);
         return ResponseEntity.ok().build();

src/main/java/com/example/solidconnection/admin/university/dto/AdminUnivApplyInfoResponse.java

@@ -7,10 +7,10 @@
 import java.util.Map;
 
 public record AdminUnivApplyInfoResponse(
-        Long id,
+        long id,
         long termId,
         Long homeUniversityId,
-        Long hostUniversityId,
+        long hostUniversityId,
         String koreanName,
         Integer studentCapacity,
         SemesterAvailableForDispatch semesterAvailableForDispatch,

src/main/java/com/example/solidconnection/admin/university/service/AdminUnivApplyInfoService.java

@@ -22,11 +22,10 @@
 import com.example.solidconnection.university.domain.HostUniversity;
 import com.example.solidconnection.university.domain.LanguageRequirement;
 import com.example.solidconnection.university.domain.UnivApplyInfo;
+import com.example.solidconnection.university.repository.HomeUniversityRepository;
 import com.example.solidconnection.university.repository.HostUniversityRepository;
-import com.example.solidconnection.university.repository.LanguageRequirementRepository;
 import com.example.solidconnection.university.repository.LikedUnivApplyInfoRepository;
 import com.example.solidconnection.university.repository.UnivApplyInfoRepository;
-import com.example.solidconnection.university.repository.HomeUniversityRepository;
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
@@ -45,7 +44,6 @@ public class AdminUnivApplyInfoService {
     private final AdminUnivApplyInfoRowSaver rowSaver;
     private final UnivApplyInfoRepository univApplyInfoRepository;
     private final HostUniversityRepository hostUniversityRepository;
-    private final LanguageRequirementRepository languageRequirementRepository;
     private final LikedUnivApplyInfoRepository likedUnivApplyInfoRepository;
     private final ApplicationRepository applicationRepository;
 
@@ -78,6 +76,24 @@ public UnivApplyInfoImportResponse importUnivApplyInfos(UnivApplyInfoImportReque
         return new UnivApplyInfoImportResponse(rows.size(), createdUniversities);
     }
 
+    private void validateColumnMappings(Map<String, String> columnMappings) {
+        boolean hasBlankEntry = columnMappings.entrySet().stream()
+                .anyMatch(e -> e.getKey().isBlank() || e.getValue().isBlank());
+        if (hasBlankEntry) {
+            throw new CustomException(INVALID_INPUT, "컬럼 매핑의 키와 값은 공백일 수 없습니다");
+        }
+    }
+
+    private void validateTermExists(Long termId) {
+        termRepository.findById(termId)
+                .orElseThrow(() -> new CustomException(TERM_NOT_FOUND));
+    }
+
+    private HomeUniversity findHomeUniversity(Long homeUniversityId) {
+        return homeUniversityRepository.findById(homeUniversityId)
+                .orElseThrow(() -> new CustomException(HOME_UNIVERSITY_NOT_FOUND));
+    }
+
     @Transactional
     @DefaultCacheOut(
             key = {"univApplyInfoTextSearch", "university:recommend:general"},
@@ -131,7 +147,7 @@ private HostUniversity findHostUniversity(Long hostUniversityId) {
             cacheManager = "customCacheManager",
             prefix = true
     )
-    public AdminUnivApplyInfoResponse updateUnivApplyInfo(Long id, AdminUnivApplyInfoUpdateRequest request) {
+    public AdminUnivApplyInfoResponse updateUnivApplyInfo(long id, AdminUnivApplyInfoUpdateRequest request) {
         UnivApplyInfo univApplyInfo = univApplyInfoRepository.findById(id)
                 .orElseThrow(() -> new CustomException(UNIV_APPLY_INFO_NOT_FOUND));
 
@@ -165,35 +181,18 @@ public AdminUnivApplyInfoResponse updateUnivApplyInfo(Long id, AdminUnivApplyInf
             cacheManager = "customCacheManager",
             prefix = true
     )
-    public void deleteUnivApplyInfo(Long id) {
+    public void deleteUnivApplyInfo(long id) {
         UnivApplyInfo univApplyInfo = univApplyInfoRepository.findById(id)
                 .orElseThrow(() -> new CustomException(UNIV_APPLY_INFO_NOT_FOUND));
         validateNoReferences(id);
         univApplyInfoRepository.delete(univApplyInfo);
     }
 
-    private void validateNoReferences(Long id) {
+    private void validateNoReferences(long id) {
         if (likedUnivApplyInfoRepository.existsByUnivApplyInfoId(id)
                 || applicationRepository.existsByChoicesUnivApplyInfoId(id)) {
             throw new CustomException(UNIV_APPLY_INFO_HAS_REFERENCES);
         }
     }
 
-    private void validateColumnMappings(Map<String, String> columnMappings) {
-        boolean hasBlankEntry = columnMappings.entrySet().stream()
-                .anyMatch(e -> e.getKey().isBlank() || e.getValue().isBlank());
-        if (hasBlankEntry) {
-            throw new CustomException(INVALID_INPUT, "컬럼 매핑의 키와 값은 공백일 수 없습니다");
-        }
-    }
-
-    private void validateTermExists(Long termId) {
-        termRepository.findById(termId)
-                .orElseThrow(() -> new CustomException(TERM_NOT_FOUND));
-    }
-
-    private HomeUniversity findHomeUniversity(Long homeUniversityId) {
-        return homeUniversityRepository.findById(homeUniversityId)
-                .orElseThrow(() -> new CustomException(HOME_UNIVERSITY_NOT_FOUND));
-    }
 }

src/test/java/com/example/solidconnection/admin/university/service/AdminUnivApplyInfoServiceTest.java

@@ -442,7 +442,7 @@ class 지원_정보_생성 {
 
             // then
             assertAll(
-                    () -> assertThat(response.id()).isNotNull(),
+                    () -> assertThat(response.id()).isPositive(),
                     () -> assertThat(response.termId()).isEqualTo(term.getId()),
                     () -> assertThat(response.homeUniversityId()).isEqualTo(homeUniversity.getId()),
                     () -> assertThat(response.hostUniversityId()).isEqualTo(hostUniversity.getId()),