Skip to content

Commit 4622ace

Browse files
authored
refactor: university_info_for_apply 미사용 컬럼 제거 (#775)
- UnivApplyInfo 엔티티에서 tuitionFeeType, detailsForApply, detailsForMajor, detailsForEnglishCourse, details 필드 제거 - TuitionFeeType 열거형 삭제 - UnivApplyInfoColumn에서 대응 enum 상수 5개 제거 - AdminUnivApplyInfoRowSaver의 ImportData 및 switch case 정리 - data.sql INSERT 구문에서 제거된 컬럼 반영 - V54 마이그레이션으로 DB 컬럼 DROP
1 parent c807bfc commit 4622ace

7 files changed

Lines changed: 45 additions & 132 deletions

File tree

src/main/java/com/example/solidconnection/admin/university/service/AdminUnivApplyInfoRowSaver.java

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import com.example.solidconnection.university.domain.LanguageRequirement;
1414
import com.example.solidconnection.university.domain.LanguageTestType;
1515
import com.example.solidconnection.university.domain.SemesterAvailableForDispatch;
16-
import com.example.solidconnection.university.domain.TuitionFeeType;
1716
import com.example.solidconnection.university.domain.UnivApplyInfo;
1817
import com.example.solidconnection.university.repository.HostUniversityRepository;
1918
import com.example.solidconnection.university.repository.UnivApplyInfoRepository;
@@ -55,17 +54,12 @@ public String save(
5554
homeUniversity,
5655
data.universityKoreanName,
5756
data.studentCapacity,
58-
data.tuitionFeeType,
5957
data.semesterAvailableForDispatch,
6058
data.semesterRequirement,
6159
data.detailsForLanguage,
6260
data.gpaRequirement,
6361
data.gpaRequirementCriteria,
64-
data.detailsForApply,
65-
data.detailsForMajor,
6662
data.detailsForAccommodation,
67-
data.detailsForEnglishCourse,
68-
data.details,
6963
data.extraInfo.isEmpty() ? null : data.extraInfo,
7064
new HashSet<>(),
7165
hostUniversity
@@ -124,14 +118,6 @@ private void applyStructuredField(ImportData data, String header, String fieldNa
124118
throw new CustomException(INVALID_INPUT, "선발 인원은 정수여야 합니다: '" + value + "'");
125119
}
126120
}
127-
case "tuitionFeeType" -> {
128-
try {
129-
data.tuitionFeeType = TuitionFeeType.valueOf(value);
130-
} catch (IllegalArgumentException e) {
131-
throw new CustomException(INVALID_INPUT,
132-
"유효하지 않은 등록금 유형입니다. 가능한 값: " + validEnumValues(TuitionFeeType.values()));
133-
}
134-
}
135121
case "semesterAvailableForDispatch" -> {
136122
try {
137123
data.semesterAvailableForDispatch = SemesterAvailableForDispatch.valueOf(value);
@@ -144,11 +130,7 @@ private void applyStructuredField(ImportData data, String header, String fieldNa
144130
case "detailsForLanguage" -> applyWithLength(value, 2000, s -> data.detailsForLanguage = s);
145131
case "gpaRequirement" -> applyWithLength(value, 100, s -> data.gpaRequirement = s);
146132
case "gpaRequirementCriteria" -> applyWithLength(value, 100, s -> data.gpaRequirementCriteria = s);
147-
case "detailsForApply" -> applyWithLength(value, 3000, s -> data.detailsForApply = s);
148-
case "detailsForMajor" -> applyWithLength(value, 3000, s -> data.detailsForMajor = s);
149133
case "detailsForAccommodation" -> applyWithLength(value, 2000, s -> data.detailsForAccommodation = s);
150-
case "detailsForEnglishCourse" -> applyWithLength(value, 1000, s -> data.detailsForEnglishCourse = s);
151-
case "details" -> applyWithLength(value, 3000, s -> data.details = s);
152134
default -> data.extraInfo.put(header, value);
153135
}
154136
}
@@ -209,17 +191,12 @@ private static class ImportData {
209191
String accommodationUrl;
210192
String detailsForLocal;
211193
Integer studentCapacity;
212-
TuitionFeeType tuitionFeeType;
213194
SemesterAvailableForDispatch semesterAvailableForDispatch;
214195
String semesterRequirement;
215196
String detailsForLanguage;
216197
String gpaRequirement;
217198
String gpaRequirementCriteria;
218-
String detailsForApply;
219-
String detailsForMajor;
220199
String detailsForAccommodation;
221-
String detailsForEnglishCourse;
222-
String details;
223200
Map<String, String> extraInfo = new HashMap<>();
224201
Map<LanguageTestType, String> languageRequirements = new HashMap<>();
225202
}

src/main/java/com/example/solidconnection/university/domain/TuitionFeeType.java

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/main/java/com/example/solidconnection/university/domain/UnivApplyInfo.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ public class UnivApplyInfo extends BaseEntity {
5151
@Column(name = "student_capacity")
5252
private Integer studentCapacity;
5353

54-
@Column(name = "tuition_fee_type")
55-
@Enumerated(EnumType.STRING)
56-
private TuitionFeeType tuitionFeeType;
57-
5854
@Column(name = "semester_available_for_dispatch")
5955
@Enumerated(EnumType.STRING)
6056
private SemesterAvailableForDispatch semesterAvailableForDispatch;
@@ -71,21 +67,9 @@ public class UnivApplyInfo extends BaseEntity {
7167
@Column(name = "gpa_requirement_criteria", length = 100)
7268
private String gpaRequirementCriteria;
7369

74-
@Column(name = "details_for_apply", length = 3000)
75-
private String detailsForApply;
76-
77-
@Column(name = "details_for_major", length = 3000)
78-
private String detailsForMajor;
79-
8070
@Column(name = "details_for_accommodation", length = 2000)
8171
private String detailsForAccommodation;
8272

83-
@Column(name = "details_for_english_course", length = 1000)
84-
private String detailsForEnglishCourse;
85-
86-
@Column(name = "details", length = 3000)
87-
private String details;
88-
8973
@JdbcTypeCode(SqlTypes.JSON)
9074
@Column(name = "extra_info", columnDefinition = "JSON")
9175
private Map<String, String> extraInfo;

src/main/java/com/example/solidconnection/university/domain/UnivApplyInfoColumn.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,12 @@ public enum UnivApplyInfoColumn {
1616
UNIVERSITY_ACCOMMODATION_URL("universityAccommodationUrl"),
1717
UNIVERSITY_DETAILS_FOR_LOCAL("universityDetailsForLocal"),
1818
STUDENT_CAPACITY("studentCapacity"),
19-
TUITION_FEE_TYPE("tuitionFeeType"),
2019
SEMESTER_AVAILABLE_FOR_DISPATCH("semesterAvailableForDispatch"),
2120
SEMESTER_REQUIREMENT("semesterRequirement"),
2221
DETAILS_FOR_LANGUAGE("detailsForLanguage"),
2322
GPA_REQUIREMENT("gpaRequirement"),
2423
GPA_REQUIREMENT_CRITERIA("gpaRequirementCriteria"),
25-
DETAILS_FOR_APPLY("detailsForApply"),
26-
DETAILS_FOR_MAJOR("detailsForMajor"),
2724
DETAILS_FOR_ACCOMMODATION("detailsForAccommodation"),
28-
DETAILS_FOR_ENGLISH_COURSE("detailsForEnglishCourse"),
29-
DETAILS("details"),
3025
;
3126

3227
private final String fieldName;

0 commit comments

Comments
 (0)