Address Devin comments

Author: papeh

Build/Agent/Setup-InstallerBuild.ps1

@@ -176,6 +176,7 @@ Write-Host "`n--- Checking Helper Repositories ---" -ForegroundColor Yellow
 $helperRepos = @(
 	@{ Name = "FwHelps"; Path = "DistFiles/Helps" },
 	@{ Name = "FwLocalizations"; Path = "Localizations" },
+	@{ Name = "genericinstaller"; Path = "PatchableInstaller" },
 	@{ Name = "liblcm"; Path = "Localizations/LCMRepo" }
 )
 
@@ -198,7 +199,7 @@ foreach ($repo in $helperRepos) {
 	} else {
 		Write-Host "[MISSING] $($repo.Name): $displayPath" -ForegroundColor Red
 		$missingRepos += $repo
-		if ($repo.Name -eq 'liblcm') {
+		if ($repo.Name -eq 'liblcm' -and $env:LcmRootDir) {
 			$issues += "Missing helper repository: $($repo.Name) (expected at LcmRootDir=$env:LcmRootDir)"
 		} else {
 			$issues += "Missing helper repository: $($repo.Name)"

Setup-Developer-Machine.ps1

@@ -205,7 +205,7 @@ if ($InstallerDeps) {
 	# Special case: liblcm is found via the LcmRootDir environment variable
 	$localizationsPath = Join-Path $scriptDir "Localizations"
 	$lcmTarget = Join-Path $localizationsPath "LCMRepo"
-	if ($env:LcmRootDir -and (Test-Path Join-Path $env:LcmRootDir ".git")) {
+	if ($env:LcmRootDir -and (Test-Path (Join-Path $env:LcmRootDir ".git"))) {
 		Write-Host "[OK] liblcm already exists at $env:LcmRootDir" -ForegroundColor Green
 	} elseif (Test-Path $lcmTarget) {
 		$env:LcmRootDir = $lcmTarget
@@ -290,7 +290,7 @@ $env:PATH = [Environment]::GetEnvironmentVariable('PATH', 'Machine') + ';' + [En
 
 Write-Host "`n--- Configuring Environment Variables ---" -ForegroundColor Yellow
 
-if ($env:LcmRootDir -and (Test-Path Join-Path $env:LcmRootDir ".git") -and
+if ($env:LcmRootDir -and (Test-Path (Join-Path $env:LcmRootDir ".git")) -and
 		$PSCmdlet.ShouldProcess('LcmRootDir', 'Set LcmRootDir for the current user')) {
 	[Environment]::SetEnvironmentVariable('LcmRootDir', $env:LcmRootDir, 'User')
 }