From 8078bb65ded9f81e87902da055554713effd06b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harold=20Gim=C3=A9nez?= Date: Wed, 24 Aug 2011 20:14:32 -0400 Subject: [PATCH] Use ruby warnings by default --- lib/rake/testtask.rb | 2 +- test/test_rake_test_task.rb | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/rake/testtask.rb b/lib/rake/testtask.rb index 5cae95c5d..348bcc481 100644 --- a/lib/rake/testtask.rb +++ b/lib/rake/testtask.rb @@ -85,7 +85,7 @@ def initialize(name=:test) @options = nil @test_files = nil @verbose = false - @warning = false + @warning = true @loader = :rake @ruby_opts = [] @description = "Run tests" + (@name == :test ? "" : " for #{@name}") diff --git a/test/test_rake_test_task.rb b/test/test_rake_test_task.rb index 5c4be797c..2007671a1 100644 --- a/test/test_rake_test_task.rb +++ b/test/test_rake_test_task.rb @@ -11,6 +11,7 @@ def test_initialize assert_equal ['lib'], tt.libs assert_equal 'test/test*.rb', tt.pattern assert_equal false, tt.verbose + assert_equal true, tt.warning assert Task.task_defined?(:test) end @@ -19,14 +20,14 @@ def test_initialize_override t.description = "Run example tests" t.libs = ['src', 'ext'] t.pattern = 'test/tc_*.rb' - t.verbose = true + t.verbose = false end refute_nil tt assert_equal "Run example tests", tt.description assert_equal :example, tt.name assert_equal ['src', 'ext'], tt.libs assert_equal 'test/tc_*.rb', tt.pattern - assert_equal true, tt.verbose + assert_equal false, tt.verbose assert Task.task_defined?(:example) end @@ -48,12 +49,13 @@ def test_libs_equals path = %w[lib A B].join File::PATH_SEPARATOR - assert_equal "-I\"#{path}\"", test_task.ruby_opts_string + assert_equal "-w -I\"#{path}\"", test_task.ruby_opts_string end def test_libs_equals_empty test_task = Rake::TestTask.new do |t| - t.libs = [] + t.libs = [] + t.warning = false end assert_equal '', test_task.ruby_opts_string