lint

Author: Rom1-B

.github/workflows/continuous-integration.yml

@@ -20,7 +20,7 @@ jobs:
     name: "Generate CI matrix"
     uses: "glpi-project/plugin-ci-workflows/.github/workflows/generate-ci-matrix.yml@v1"
     with:
-      glpi-version: "11.0.x"
+      glpi-version: "12.0.x"
   ci:
     name: "GLPI ${{ matrix.glpi-version }} - php:${{ matrix.php-version }} - ${{ matrix.db-image }}"
     needs: "generate-ci-matrix"

inc/container.class.php

@@ -1935,7 +1935,7 @@ public static function preItem(CommonDBTM $item)
             $entities = getSonsOf(getTableForItemType('Entity'), $loc_c->fields['entities_id']);
         }
 
-        if (count($item->fields) === 0) {
+        if ($item->fields === []) {
             $item->fields = $item->input;
         }
 

inc/containerdisplaycondition.class.php

@@ -383,7 +383,7 @@ public static function removeBlackListedOption($array, $itemtype_class)
                     $main_table == getTableForItemType($itemtype_class)
                 ) {
                     foreach ($foreignKey as $foreign_class) {
-                        if (!is_array($foreign_class) && getTableNameForForeignKeyField($foreign_class) != getTableForItemType(Location::getType())) {
+                        if (!is_array($foreign_class) && getTableNameForForeignKeyField($foreign_class) !== getTableForItemType(Location::getType())) {
                             $allowed_table[] = getTableForItemType(getItemtypeForForeignKeyField($foreign_class));
                         }
                     }

inc/destinationfield.class.php

@@ -106,7 +106,7 @@ public function applyConfiguratedValueToInputUsingAnswers(
                         continue;
                     }
 
-                    /** @var object{field_name: string} $item */
+                    /** @var CommonGLPI&object{field_name: string} $item */
                     $item = getItemForItemtype($itemtype);
                     $field = new PluginFieldsField();
                     if (!$field->getFromDBByCrit(['name' => $item->field_name])) {

src/Controller/QuestionTypeAjaxController.php

@@ -76,7 +76,7 @@ public function __invoke(Request $request): Response
         $current_container = PluginFieldsContainer::getById((int) $block_id);
         $current_field = PluginFieldsField::getById($current_field_id);
 
-        if (!$current_container || !$current_field || empty($current_field->fields)) {
+        if (!$current_container || !$current_field || $current_field->fields === []) {
             return new Response('Invalid container or field', Response::HTTP_BAD_REQUEST);
         }
 

templates/container_display_conditions.html.twig

@@ -86,7 +86,6 @@
                                                data-bs-toggle="tooltip" data-bs-placement="top">
                                           <i class="ti ti-trash"></i>
                                        </button>
-                                       <input type="hidden" name="_glpi_csrf_token" value="{{ csrf_token() }}" />
                                     </form>
                                  </td>
                               </tr>

templates/forms/container_display_condition.html.twig

@@ -92,7 +92,6 @@
                         <span>{{ _x('button', 'Add') }}</span>
                      </button>
                   {% endif %}
-                  <input type="hidden" name="_glpi_csrf_token" value="{{ csrf_token() }}" />
                </div>
             </div> {# .row #}
          </div> {# .flex-row #}

templates/forms/status_override.html.twig

@@ -64,7 +64,6 @@
                         <span>{{ _x('button', 'Update') }}</span>
                      </button>
                   {% endif %}
-                  <input type="hidden" name="_glpi_csrf_token" value="{{ csrf_token() }}" />
                </div>
             </div> {# .row #}
          </div> {# .flex-row #}

templates/forms/tab_container.html.twig

@@ -42,7 +42,6 @@
                     {{ html_fields|raw }}
 
                     {% if canedit %}
-                            <input type="hidden" name="_glpi_csrf_token" value="{{ csrf_token() }}" />
                             <div class="card-body mt-3 mx-n2 border-top d-flex flex-row-reverse align-items-start flex-wrap">
                                 <button class="btn btn-primary me-2" type="submit" name="update_fields_values" value="1">
                                     <i class="ti ti-device-floppy"></i>

templates/status_overrides.html.twig

@@ -95,7 +95,6 @@
                                                data-bs-toggle="tooltip" data-bs-placement="top">
                                           <i class="ti ti-trash"></i>
                                        </button>
-                                       <input type="hidden" name="_glpi_csrf_token" value="{{ csrf_token() }}" />
                                     </form>
                                  </td>
                               </tr>