Skip to content

fix(discovery): use QString to avoid dangling QStringBuilder. - #10550

Merged
Rello merged 3 commits into
masterfrom
bugfix/10535/qstringbuilder
Aug 8, 2026
Merged

fix(discovery): use QString to avoid dangling QStringBuilder.#10550
Rello merged 3 commits into
masterfrom
bugfix/10535/qstringbuilder

Conversation

@camilasan

@camilasan camilasan commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fix for #10535.

auto on a QString concat keeps a QStringBuilder referencing destroyed temporaries, giving a garbage size allocation that crashes on Qt 6.4.2.

Checklist

AI (if applicable)

@camilasan camilasan added this to the 34.0.2 milestone Aug 6, 2026
@camilasan

camilasan commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

/backport to stable-34.0

@camilasan
camilasan force-pushed the bugfix/10535/qstringbuilder branch from 5f18785 to 8375783 Compare August 6, 2026 18:20
@camilasan camilasan changed the title fix(discovery): declare QString to avoid dangling QStringBuilder. fix(discovery): use QString to avoid dangling QStringBuilder. Aug 6, 2026
@camilasan camilasan mentioned this pull request Aug 6, 2026
Closed
8 tasks
@camilasan
fix(discovery): use QString to avoid dangling QStringBuilder.
c26101e 
Fix for #10535.

auto on a QString concat keeps a QStringBuilder referencing destroyed
temporaries, giving a garbage size allocation that crashes on Qt 6.4.2.

Assisted-by: Claude Code:claude-opus-4-8
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
camilasan force-pushed the bugfix/10535/qstringbuilder branch from 8375783 to c26101e Compare August 6, 2026 18:24
@CarlSchwan

CarlSchwan commented Aug 7, 2026

Copy link
Copy Markdown
Member

Just for info, this bug with auto+QString was fixed in a newer version of Qt (don't know which one)

@ukretschmer

ukretschmer commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Just for info, this bug with auto+QString was fixed in a newer version of Qt (don't know which one)

@CarlSchwan It might be related to QTBUG-104354 (Document QStringBuilder's auto gotcha) which was closed in Release 6.6.0

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10550.zip

Digest: sha256:0e9d5218afdc2b6674866b5b1bec174b22d07585ef9664eccf7ae5070cb13b84

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Rello
Rello merged commit c104b64 into master Aug 8, 2026
23 checks passed
@Rello
Rello deleted the bugfix/10535/qstringbuilder branch August 8, 2026 09:43
@backportbot backportbot Bot mentioned this pull request Aug 8, 2026
Open
@camilasan

camilasan commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Just for info, this bug with auto+QString was fixed in a newer version of Qt (don't know which one)

I know, this is fixed in 6.10 which we use in our AppImage, but the PPA package uses 6.4. that is why the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claucambra claucambra claucambra approved these changes
@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner
@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner
@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

34.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

@camilasan @CarlSchwan @ukretschmer @claucambra @Rello