build(bazel): link complete RNTester against source React

Model Package.swift's React product as the aggregate of all generated regular targets, add the missing DevTools runtime settings targets, and preserve required macOS frameworks. The default-off rn_from_source mode now builds and launches RNTester without embedding React.framework while retaining prebuilt Hermes and ReactNativeDependencies as bootstrap inputs.

Complete application resources as part of the same end-to-end milestone: save Metro assets returned by runBuild, compile the macOS asset catalog and storyboard, and embed app icons, privacy manifest, and entitlements. Verified both source and prebuilt modes build; source mode launches offline with the real native-example bundle and tab icons.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Saadnajmi

docs/bazel.md

@@ -159,6 +159,14 @@ prebuilt-XCFramework link. Specifically:
   and the RCTLinking/RCTPushNotification modules built from source (not in the prebuilt
   framework). Its embedded `main.jsbundle` contains the real native-example JS (no
   stubs), and no rn-tester source is modified or `#ifdef`'d out.
+* **React can be linked from source** with
+  `bazel build //packages/rn-tester/RNTester-macOS:app --//:rn_from_source=true`.
+  This mode builds the generated 58-target SwiftPM graph, links the resulting static
+  libraries into RNTester (no `React.framework` in the app), and launches offline.
+  Hermes and ReactNativeDependencies remain prebuilt bootstrap inputs.
+* **Resources are complete**: Metro copies its 45 image/XML assets (including all six
+  bottom-nav icons), while rules_apple compiles the macOS asset catalog/storyboard and
+  embeds `Assets.car`, `AppIcon.icns`, entitlements, and `PrivacyInfo.xcprivacy`.
 
 ### Consuming the prebuilt XCFrameworks from Bazel (the header problem)
 
@@ -278,10 +286,11 @@ the repo's `enableScripts: false`), which is inert for Yarn and not published.
 `swift package dump-package`, normalizes the resolved macOS target metadata, and writes
 `packages/react-native/bazel/spm_targets.bzl`. `rn_spm_native_graph()` turns those 56
 targets into `spm_*` Bazel libraries without adding BUILD files throughout the React
-source tree. The graph now compiles through `spm_React_RCTAppDelegate` (including a
+source tree. The graph now compiles through the complete `spm_React` product (including a
 Bazel-generated `FBReactNativeSpec`) using a canonical header projection generated
-from source. `--//:rn_from_source=true` is an experimental, default-off app wiring
-while that source mode is validated end to end. Then output the same `.xcframework`s via
+from source. `--//:rn_from_source=true` builds and launches RNTester but remains
+default-off until Hermes and ReactNativeDependencies are available from a fresh checkout.
+Then output the same `.xcframework`s via
 `apple_static_xcframework`, swapped in behind the P3 alias + `--//:rn_from_source`:
 
 * **FA — Hermes**: keep the prebuilt Hermes (`http_archive`) initially; optionally wrap

packages/react-native/BUILD.bazel

@@ -91,16 +91,19 @@ cc_library(
 objc_library(
     name = "rntester_extra_rn_modules",
     srcs = [
-        "Libraries/LinkingIOS/RCTLinkingManager.mm",
-        "Libraries/LinkingIOS/RCTLinkingPlugins.h",
         "Libraries/PushNotificationIOS/RCTPushNotificationManager.mm",
         "Libraries/PushNotificationIOS/RCTPushNotificationPlugins.h",
         "Libraries/PushNotificationIOS/RCTPushNotificationPlugins.mm",
-    ],
+    ] + select({
+        "//:rn_from_source_enabled": [],
+        "//conditions:default": [
+            "Libraries/LinkingIOS/RCTLinkingManager.mm",
+            "Libraries/LinkingIOS/RCTLinkingPlugins.h",
+        ],
+    }),
     tags = ["manual"],
     visibility = ["//visibility:public"],
     deps = [
-        ":rct_linking_hdrs",
         ":rct_pushnotification_hdrs",
         ":rn_cxx_headers",
         "@rn_prebuilt_xcframeworks//:ReactNativeDependencies_headers",
@@ -110,6 +113,7 @@ objc_library(
             "@rn_source_headers//:headers",
         ],
         "//conditions:default": [
+            ":rct_linking_hdrs",
             "@rn_prebuilt_xcframeworks//:React",
             "@rn_prebuilt_xcframeworks//:React_headers",
         ],

packages/react-native/Package.swift

@@ -277,11 +277,23 @@ let reactTurboModuleCore = RNTarget(
   dependencies: [.reactNativeDependencies, .reactDebug, .reactFeatureFlags, .reactUtils, .reactPerfLogger, .reactCxxReact, .reactTurboModuleBridging, .yoga, .reactRuntimeExecutor]
 )
 
+let reactDevToolsRuntimeSettings = RNTarget(
+  name: .reactDevToolsRuntimeSettings,
+  path: "ReactCommon/devtoolsruntimesettings",
+  dependencies: [.jsi]
+)
+
+let reactDevToolsRuntimeSettingsModule = RNTarget(
+  name: .reactDevToolsRuntimeSettingsModule,
+  path: "ReactCommon/react/nativemodule/devtoolsruntimesettings",
+  dependencies: [.jsi, .reactDevToolsRuntimeSettings, .reactTurboModuleCore]
+)
+
 /// React-defaultsnativemodule.podspec
 let reactTurboModuleCoreDefaults = RNTarget(
   name: .reactTurboModuleCoreDefaults,
   path: "ReactCommon/react/nativemodule/defaults",
-  dependencies: [.reactNativeDependencies, .jsi, .reactJsiExecutor, .reactTurboModuleCore]
+  dependencies: [.reactNativeDependencies, .jsi, .reactJsiExecutor, .reactTurboModuleCore, .reactDevToolsRuntimeSettingsModule]
 )
 
 /// React-microtasknativemodule.podspec
@@ -603,6 +615,8 @@ let targets = [
   reactCoreModules,
   reactTurboModuleBridging,
   reactTurboModuleCore,
+  reactDevToolsRuntimeSettings,
+  reactDevToolsRuntimeSettingsModule,
   reactTurboModuleCoreDefaults,
   reactTurboModuleCoreMicrotasks,
   reactIdleCallbacksNativeModule,
@@ -779,6 +793,8 @@ extension String {
   static let reactCoreModules = "React-CoreModules"
   static let reactTurboModuleBridging = "ReactCommon/turbomodule/bridging"
   static let reactTurboModuleCore = "ReactCommon/turbomodule/core"
+  static let reactDevToolsRuntimeSettings = "ReactCommon/devtoolsruntimesettings"
+  static let reactDevToolsRuntimeSettingsModule = "ReactCommon/turbomodule/devtoolsruntimesettings"
   static let reactTurboModuleCoreDefaults = "ReactCommon/turbomodule/core/defaults"
   static let reactTurboModuleCoreMicrotasks = "ReactCommon/turbomodule/core/microtasks"
   static let reactIdleCallbacksNativeModule = "React-idlecallbacksnativemodule"

packages/react-native/bazel/spm_targets.bzl

@@ -3924,6 +3924,51 @@ SPM_TARGETS = {
             "CoreFoundation",
         ],
     },
+    "ReactCommon/devtoolsruntimesettings": {
+        "bazel_name": "spm_ReactCommon_devtoolsruntimesettings",
+        "type": "regular",
+        "path": "ReactCommon/devtoolsruntimesettings",
+        "deps": [
+            "React-jsi",
+        ],
+        "srcs": [
+            "ReactCommon/devtoolsruntimesettings/**/*.c",
+            "ReactCommon/devtoolsruntimesettings/**/*.cc",
+            "ReactCommon/devtoolsruntimesettings/**/*.cpp",
+            "ReactCommon/devtoolsruntimesettings/**/*.m",
+            "ReactCommon/devtoolsruntimesettings/**/*.mm",
+        ],
+        "hdrs": [
+            "ReactCommon/devtoolsruntimesettings/**/*.def",
+            "ReactCommon/devtoolsruntimesettings/**/*.h",
+            "ReactCommon/devtoolsruntimesettings/**/*.hh",
+            "ReactCommon/devtoolsruntimesettings/**/*.hpp",
+            "ReactCommon/devtoolsruntimesettings/**/*.inc",
+        ],
+        "excludes": [],
+        "copts": [
+            "-std=c++20",
+        ],
+        "defines": [
+            "USE_HERMES=1",
+        ],
+        "debug_defines": [
+            "DEBUG",
+        ],
+        "release_defines": [
+            "NDEBUG",
+        ],
+        "includes": [
+            ".build/headers",
+            ".build/headers/React",
+            "ReactCommon",
+            "ReactCommon/devtoolsruntimesettings",
+            "ReactCommon/jsi",
+            "third-party/ReactNativeDependencies.xcframework",
+            "third-party/ReactNativeDependencies.xcframework/Headers",
+        ],
+        "sdk_frameworks": [],
+    },
     "ReactCommon/turbomodule/bridging": {
         "bazel_name": "spm_ReactCommon_turbomodule_bridging",
         "type": "regular",
@@ -4073,6 +4118,7 @@ SPM_TARGETS = {
             "React-jsi",
             "React-jsiexecutor",
             "ReactCommon/turbomodule/core",
+            "ReactCommon/turbomodule/devtoolsruntimesettings",
             "ReactNativeDependencies",
         ],
         "srcs": [
@@ -4110,6 +4156,7 @@ SPM_TARGETS = {
             "ReactCommon",
             "ReactCommon/callinvoker",
             "ReactCommon/cxxreact",
+            "ReactCommon/devtoolsruntimesettings",
             "ReactCommon/jsi",
             "ReactCommon/jsiexecutor",
             "ReactCommon/jsinspector-modern",
@@ -4123,6 +4170,7 @@ SPM_TARGETS = {
             "ReactCommon/react/nativemodule/core",
             "ReactCommon/react/nativemodule/core/platform/ios",
             "ReactCommon/react/nativemodule/defaults",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings",
             "ReactCommon/react/utils",
             "ReactCommon/react/utils/platform/ios",
             "ReactCommon/reactperflogger",
@@ -4205,6 +4253,74 @@ SPM_TARGETS = {
         ],
         "sdk_frameworks": [],
     },
+    "ReactCommon/turbomodule/devtoolsruntimesettings": {
+        "bazel_name": "spm_ReactCommon_turbomodule_devtoolsruntimesettings",
+        "type": "regular",
+        "path": "ReactCommon/react/nativemodule/devtoolsruntimesettings",
+        "deps": [
+            "React-jsi",
+            "ReactCommon/devtoolsruntimesettings",
+            "ReactCommon/turbomodule/core",
+        ],
+        "srcs": [
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.c",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.cc",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.cpp",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.m",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.mm",
+        ],
+        "hdrs": [
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.def",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.h",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.hh",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.hpp",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings/**/*.inc",
+        ],
+        "excludes": [],
+        "copts": [
+            "-std=c++20",
+        ],
+        "defines": [
+            "USE_HERMES=1",
+        ],
+        "debug_defines": [
+            "DEBUG",
+        ],
+        "release_defines": [
+            "NDEBUG",
+        ],
+        "includes": [
+            ".build/headers",
+            ".build/headers/React",
+            "Libraries/FBLazyVector",
+            "React/FBReactNativeSpec",
+            "ReactCommon",
+            "ReactCommon/callinvoker",
+            "ReactCommon/cxxreact",
+            "ReactCommon/devtoolsruntimesettings",
+            "ReactCommon/jsi",
+            "ReactCommon/jsinspector-modern",
+            "ReactCommon/jsinspector-modern/network",
+            "ReactCommon/jsinspector-modern/tracing",
+            "ReactCommon/logger",
+            "ReactCommon/oscompat",
+            "ReactCommon/react/bridging",
+            "ReactCommon/react/debug",
+            "ReactCommon/react/featureflags",
+            "ReactCommon/react/nativemodule/core",
+            "ReactCommon/react/nativemodule/core/platform/ios",
+            "ReactCommon/react/nativemodule/devtoolsruntimesettings",
+            "ReactCommon/react/utils",
+            "ReactCommon/react/utils/platform/ios",
+            "ReactCommon/reactperflogger",
+            "ReactCommon/runtimeexecutor",
+            "ReactCommon/runtimeexecutor/platform/ios",
+            "ReactCommon/yoga",
+            "third-party/ReactNativeDependencies.xcframework",
+            "third-party/ReactNativeDependencies.xcframework/Headers",
+        ],
+        "sdk_frameworks": [],
+    },
     "ReactNativeDependencies": {
         "bazel_name": "spm_ReactNativeDependencies",
         "type": "binary",

packages/rn-tester/BUILD.bazel

@@ -127,10 +127,16 @@ objc_library(
 #    (mirrors how Buck2's apple prelude ingests a js_bundle as an AppleResource).
 macos_application(
     name = "RNTesterMacBazel",
+    app_icons = ["//packages/rn-tester/RNTester-macOS:app_icons"],
     bundle_id = "org.reactjs.native.RNTesterMacBazel",
+    entitlements = "//packages/rn-tester/RNTester-macOS:RNTester_macOS.entitlements",
     infoplists = ["bazel/Info.plist"],
     minimum_os_version = "14.0",
-    resources = [":rntester_macos_jsbundle"],
+    resources = [
+        ":rntester_macos_jsbundle",
+        "PrivacyInfo.xcprivacy",
+        "//packages/rn-tester/RNTester-macOS:native_resources",
+    ],
     tags = ["manual"],
     deps = [":rntester_macos_minimal_host"],
 )
@@ -164,7 +170,7 @@ objc_library(
         "@rn_prebuilt_xcframeworks//:hermes",
     ] + select({
         "//:rn_from_source_enabled": [
-            "//packages/react-native:spm_React_RCTAppDelegate",
+            "//packages/react-native:spm_React",
             "@rn_source_headers//:headers",
         ],
         "//conditions:default": [
@@ -176,10 +182,16 @@ objc_library(
 
 macos_application(
     name = "RNTesterMacBazelFull",
+    app_icons = ["//packages/rn-tester/RNTester-macOS:app_icons"],
     bundle_id = "org.reactjs.native.RNTesterMacBazelFull",
+    entitlements = "//packages/rn-tester/RNTester-macOS:RNTester_macOS.entitlements",
     infoplists = ["bazel/Info.plist"],
     minimum_os_version = "14.0",
-    resources = [":rntester_macos_jsbundle"],
+    resources = [
+        ":rntester_macos_jsbundle",
+        "PrivacyInfo.xcprivacy",
+        "//packages/rn-tester/RNTester-macOS:native_resources",
+    ],
     tags = ["manual"],
     visibility = ["//packages/rn-tester/RNTester-macOS:__pkg__"],
     deps = [":rntester_macos_full_host"],

packages/rn-tester/RNTester-macOS/BUILD.bazel

@@ -2,6 +2,18 @@
 
 package(default_visibility = ["//visibility:public"])
 
+filegroup(
+    name = "app_icons",
+    srcs = glob(["Assets.xcassets/**"]),
+)
+
+filegroup(
+    name = "native_resources",
+    srcs = ["Base.lproj/Main.storyboard"],
+)
+
+exports_files(["RNTester_macOS.entitlements"])
+
 alias(
     name = "app",
     actual = "//packages/rn-tester:RNTesterMacBazelFull",

packages/rn-tester/bazel/bundle.js

@@ -216,6 +216,25 @@ function resolveAssetFiles(filePath) {
     .map(name => path.join(dir, name));
   return filePaths.length ? {type: 'assetFiles', filePaths} : null;
 }
+
+function saveAssets(assets, assetsDest) {
+  for (const asset of assets) {
+    asset.scales.forEach((scale, index) => {
+      const suffix = scale === 1 ? '' : `@${scale}x`;
+      const relativeDir = asset.httpServerLocation
+        .slice(1)
+        .replace(/\.\.\//g, '_');
+      const destination = path.join(
+        assetsDest,
+        relativeDir,
+        `${asset.name}${suffix}.${asset.type}`,
+      );
+      fs.mkdirSync(path.dirname(destination), {recursive: true});
+      fs.copyFileSync(asset.files[index], destination);
+    });
+  }
+}
+
 const originalGetOrComputeSha1 = DependencyGraph.prototype.getOrComputeSha1;
 DependencyGraph.prototype.getOrComputeSha1 = async function (filename) {
   try {
@@ -277,7 +296,7 @@ async function main() {
   // Use `bundleOut` (verbatim) rather than `out`; Metro's runBuild rewrites
   // `out` through `.replace(/(\.js)?$/, '.js')`, which would turn our declared
   // Bazel output `RNTesterApp.macos.jsbundle` into `...jsbundle.js`.
-  await Metro.runBuild(config, {
+  const result = await Metro.runBuild(config, {
     entry: entryFile,
     platform: 'macos',
     dev: false,
@@ -286,6 +305,12 @@ async function main() {
     assets: Boolean(assetsDest),
     assetsDest,
   });
+  if (assetsDest != null) {
+    if (result.assets == null) {
+      throw new Error("Assets missing from Metro's runBuild result");
+    }
+    saveAssets(result.assets, assetsDest);
+  }
 }
 
 main().catch(err => {