don't show final stop name twice

Author: digitaltom

app/lib/mapforge/trains/tools.rb

@@ -62,6 +62,13 @@ def self.next_departures(stops, now)
              .sort_by { |stop| stop[:departure] }
       end
 
+      # The next train that ends at a station. It has no departure, so #next_departures never sees
+      # it, and no destination either, because the station it is standing in is the destination.
+      def self.next_arrival(stops, now)
+        stops.select { |stop| stop[:departure].nil? && stop[:arrival] && stop[:arrival] >= now }
+             .min_by { |stop| stop[:arrival] }
+      end
+
       # How many minutes late a stop is. The live time and the planned one have to be the same event:
       # comparing an arrival against a planned departure would report the stop time as being early.
       def self.delay(stop)
@@ -101,17 +108,21 @@ def self.delay_colors(minutes)
       # route_setup left in label-title:
       #
       #   12:20 (12:18) → Gräfenberg (+2)
-      #   12:35 → Nürnberg Nordost
+      #   12:35
       #
       # Planned departure, planned arrival in brackets where the train does not start here, terminus,
-      # and how late it currently is.
+      # and how late it currently is. A train that ends here has no departure and no destination but
+      # this station, whose name is above the board already, so its line is the planned arrival alone.
       def self.board_label(stops, now)
-        next_departures(stops, now).map { |stop|
-          minutes = ((stop[:departure] - stop[:planned]) / 60).round
+        lines = next_departures(stops, now).map { |stop|
           arrival = stop[:planned_arrival]
-          "#{hhmm(stop[:planned])}#{" (#{hhmm(arrival)})" if arrival} " \
-            "→ #{stop[:destination]}#{" (+#{minutes})" unless minutes.zero?}"
-        }.join("\n")
+          [ stop[:planned], "#{hhmm(stop[:planned])}#{" (#{hhmm(arrival)})" if arrival} → #{stop[:destination]}",
+            ((stop[:departure] - stop[:planned]) / 60).round ]
+        }
+        ends_here = next_arrival(stops, now)
+        lines << [ ends_here[:planned], hhmm(ends_here[:planned]), delay(ends_here) ] if ends_here
+        lines.sort_by(&:first).map { |_time, text, minutes| "#{text}#{" (+#{minutes})" unless minutes.zero?}" }
+             .join("\n")
       end
 
       # Every time here comes from the DB API and belongs to a German platform display, so it is shown

spec/lib/mapforge/trains/tools_spec.rb

@@ -151,25 +151,34 @@ def properties(minutes, at: start)
     # 10:00 UTC is 12:00 in Berlin.
     let(:noon) { Time.utc(2026, 8, 1, 10, 0) }
 
+    def board_label(stops, time) = described_class.board_label(stops, time)
+
     it "puts the planned arrival in brackets and the delay behind the destination" do
       stops = [ { destination: "Gräfenberg", planned_arrival: noon + 8.minutes,
                   planned: noon + 10.minutes, departure: noon + 12.minutes } ]
 
-      expect(described_class.board_label(stops, noon)).to eq("12:10 (12:08) → Gräfenberg (+2)")
+      expect(board_label(stops, noon)).to eq("12:10 (12:08) → Gräfenberg (+2)")
     end
 
     it "leaves out the brackets where the train starts here, and the delay where there is none" do
       stops = [ { destination: "Gräfenberg", planned: noon + 10.minutes, departure: noon + 10.minutes } ]
 
-      expect(described_class.board_label(stops, noon)).to eq("12:10 → Gräfenberg")
+      expect(board_label(stops, noon)).to eq("12:10 → Gräfenberg")
+    end
+
+    it "shows a train that ends here as its arrival alone, without a destination" do
+      stops = [ { planned_arrival: noon + 35.minutes, planned: noon + 35.minutes, arrival: noon + 37.minutes },
+                { destination: "Nürnberg", planned: noon + 40.minutes, departure: noon + 40.minutes } ]
+
+      expect(board_label(stops, noon)).to eq("12:35 (+2)\n12:40 → Nürnberg")
     end
 
     it "is one line per destination, earliest first, and empty once nothing is due" do
       stops = [ { destination: "Gräfenberg", planned: noon + 20.minutes, departure: noon + 20.minutes },
                 { destination: "Nürnberg", planned: noon + 5.minutes, departure: noon + 5.minutes } ]
 
-      expect(described_class.board_label(stops, noon)).to eq("12:05 → Nürnberg\n12:20 → Gräfenberg")
-      expect(described_class.board_label(stops, noon + 1.hour)).to eq("")
+      expect(board_label(stops, noon)).to eq("12:05 → Nürnberg\n12:20 → Gräfenberg")
+      expect(board_label(stops, noon + 1.hour)).to eq("")
     end
   end
 end