Skip to content

Time discretized weak form double adding dt #1625

Description

@lihanyu97

To be fixed soon with incoming PR.

Essentially, we pass in time_info.time() when we evaluate the residual and jacobian associated with a weak form because functional takes (double t, auto X, auto... inputs). Here t = t0 + dt. Then time_discretized_weak_form wraps around functional_weak_form by reconstructing a time_info from t and dt. This means time_info.time() called in the integrand (eg. time-dependent BCs) will give t0 + dt + dt.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions