Skip to content

Commit bbefb33

Browse files
Alexey Lesovskyclaude
andcommitted
chore: go mod tidy — pflag is a direct dependency
cmd/report/report_test.go imports pflag directly to pin the two -W failure shapes, so the indirect marking was stale and any -mod=mod build rewrote it. Tech debt [036] closed rather than carried: the fix is one line and was verified with a build and the report tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent aa86588 commit bbefb33

2 files changed

Lines changed: 18 additions & 12 deletions

File tree

docs/tech-debt.md

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,6 @@ Pre-existing, confirmed by A/B against a `master`-built binary — the feature's
4141
because WAL segment names differ only in their tail, so truncating from the right removes exactly the
4242
part that identifies the segment — the reason the column is on the screen at all.
4343

44-
### [036] `go.mod` marks `spf13/pflag` as `// indirect` although a test imports it directly
45-
46-
**Added:** 2026-08-06 (surfaced during feature: 017-feat-wal-archiver)
47-
**Severity:** Trivial
48-
**Area:** `go.mod`, `cmd/report/report_test.go`
49-
50-
The flag-definition test imports `github.com/spf13/pflag` directly, but the `require` line still
51-
carries `// indirect`. Nothing fails today — the default readonly module mode builds, tests and lints
52-
fine, and CI has no `go mod tidy -diff` gate — but any build with `-mod=mod` rewrites `go.mod` and
53-
dirties the working tree. Fix is one `go mod tidy` run at a moment when no parallel work holds the
54-
branch.
5544

5645
### [027] Messages printed after a dialog closes are never visible
5746

@@ -353,6 +342,23 @@ third unsafe consumer alongside `diff`, so fixing `diff` alone would not close t
353342

354343
## Resolved Debt
355344

345+
### [036] `go.mod` marks `spf13/pflag` as `// indirect` although a test imports it directly
346+
347+
**Added:** 2026-08-06 (surfaced during feature: 017-feat-wal-archiver)
348+
**Severity:** Trivial
349+
**Area:** `go.mod`, `cmd/report/report_test.go`
350+
351+
The flag-definition test imports `github.com/spf13/pflag` directly, but the `require` line still
352+
carries `// indirect`. Nothing fails today — the default readonly module mode builds, tests and lints
353+
fine, and CI has no `go mod tidy -diff` gate — but any build with `-mod=mod` rewrites `go.mod` and
354+
dirties the working tree. Fix is one `go mod tidy` run at a moment when no parallel work holds the
355+
branch.
356+
357+
**Resolved:** 2026-08-06, during finalization of 017-feat-wal-archiver — `go mod tidy` moved
358+
`github.com/spf13/pflag` into the direct requires, matching the direct import in
359+
`cmd/report/report_test.go`. One line; build and the report tests verified after.
360+
361+
356362
### [025] `PGresult.sort` does not bounds-check its sort key
357363

358364
**Added:** 2026-07-25 (surfaced during feature: 013-feat-activity-xmin-horizon, security audit)

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ require (
99
github.com/jehiah/go-strftime v0.0.0-20171201141054-1d33003b3869
1010
github.com/jroimartin/gocui v0.5.0
1111
github.com/spf13/cobra v1.10.2
12+
github.com/spf13/pflag v1.0.10
1213
github.com/stretchr/testify v1.11.1
1314
golang.org/x/term v0.42.0
1415
)
@@ -24,7 +25,6 @@ require (
2425
github.com/nsf/termbox-go v1.1.1 // indirect
2526
github.com/pmezard/go-difflib v1.0.0 // indirect
2627
github.com/rogpeppe/go-internal v1.14.1 // indirect
27-
github.com/spf13/pflag v1.0.10 // indirect
2828
golang.org/x/sys v0.43.0 // indirect
2929
golang.org/x/text v0.39.0 // indirect
3030
gopkg.in/yaml.v3 v3.0.1 // indirect

0 commit comments

Comments
 (0)