test

Signed-off-by: Cagri Yonca <cagri@ibm.com>

Author: CagriYonca

tests/frameworks/test_twisted_client.py

@@ -414,3 +414,103 @@ def done(_):
         assert test_span
         # Failure path must mark the span errored
         assert twisted_client_span.ec == 1
+
+    def test_agent_request_200(self) -> None:
+        """Twisted Agent.request 200 — exercises _finish_tracing success path
+        (lines 109-111, 126-129 in client.py)."""
+        response, failure = self._make_request("/")
+
+        assert failure is None
+        assert response is not None
+        assert response.code == 200
+
+        time.sleep(0.5)
+        spans = self.recorder.queued_spans()
+
+        twisted_client_span = get_first_span_by_name(spans, "twisted-client")
+        test_span = get_first_span_by_name(spans, "sdk")
+
+        assert twisted_client_span
+        assert test_span
+
+        # Same trace
+        assert twisted_client_span.t == test_span.t
+        assert twisted_client_span.p == test_span.s
+
+        assert twisted_client_span.data["http"]["status"] == 200
+        assert twisted_client_span.data["http"]["method"] == "GET"
+        assert not twisted_client_span.ec
+
+    def test_agent_request_500_marks_errored(self) -> None:
+        """Twisted Agent.request 500 — exercises `status_code >= 400` branch
+        (lines 113-114 in client.py)."""
+        response, failure = self._make_request("/500")
+
+        assert failure is None
+        assert response is not None
+        assert response.code == 500
+
+        time.sleep(0.5)
+        spans = self.recorder.queued_spans()
+
+        twisted_client_span = get_first_span_by_name(spans, "twisted-client")
+        test_span = get_first_span_by_name(spans, "sdk")
+
+        assert twisted_client_span
+        assert test_span
+
+        assert twisted_client_span.data["http"]["status"] == 500
+        assert twisted_client_span.ec == 1
+
+    def test_agent_request_response_headers(self) -> None:
+        """Twisted Agent.request captures response headers — exercises
+        extract_custom_headers in _finish_tracing (lines 117-121 in client.py)."""
+        from instana.singletons import agent as instana_agent
+
+        original = instana_agent.options.extra_http_headers
+        instana_agent.options.extra_http_headers = [
+            "X-Capture-This-Too",
+            "X-Capture-That-Too",
+        ]
+
+        try:
+            response, failure = self._make_request("/response_headers")
+        finally:
+            instana_agent.options.extra_http_headers = original
+
+        assert failure is None
+        assert response is not None
+
+        time.sleep(0.5)
+        spans = self.recorder.queued_spans()
+
+        twisted_client_span = get_first_span_by_name(spans, "twisted-client")
+        assert twisted_client_span
+
+        assert "X-Capture-This-Too" in twisted_client_span.data["http"]["header"]
+        assert (
+            twisted_client_span.data["http"]["header"]["X-Capture-This-Too"]
+            == "this too"
+        )
+        assert "X-Capture-That-Too" in twisted_client_span.data["http"]["header"]
+        assert (
+            twisted_client_span.data["http"]["header"]["X-Capture-That-Too"]
+            == "that too"
+        )
+
+    def test_agent_request_query_params_scrubbed(self) -> None:
+        """Twisted Agent.request with query params — exercises param scrubbing
+        (lines 56-61 in client.py) and sets http.params on the span."""
+        response, failure = self._make_request("/", params={"secret": "topsecret"})
+
+        assert failure is None
+        assert response is not None
+
+        time.sleep(0.5)
+        spans = self.recorder.queued_spans()
+
+        twisted_client_span = get_first_span_by_name(spans, "twisted-client")
+        assert twisted_client_span
+
+        assert twisted_client_span.data["http"]["params"] == "secret=<redacted>"
+        assert twisted_client_span.data["http"]["url"].endswith("/")