Skip to content

Commit cf812e3

Browse files
hyperpolymathclaude
andcommitted
fix(ci): repair workflows made unparseable by a blind permissions insertion
These workflow files are not valid YAML, so they have NEVER run. GitHub Actions rejects the file before creating any job: the run is recorded as `failure` with no jobs, no log and no check run, and `gh pr checks` shows no row at all. A red mark with nothing behind it to read. The cause is a sweep that added permission declarations by LINE POSITION rather than by parsing the document. Two invalid shapes resulted. permissions: read-all actions: read <- a mapping indented under a SCALAR value `read-all` is a scalar and cannot take children. It also already grants everything `actions: read` would, so the orphaned line is dropped and nothing is lost. on: permissions: contents: read <- two colons on one line, and push: `permissions` is not a valid key here Dropped entirely. VERIFIED, not assumed. Every workflow in this repository parses after the change, and the repairer refuses to write any file that does not parse and still contain jobs afterwards. Where a job-level permissions line was removed, a top-level `permissions:` remains and is read-only, so nothing is widened — and if none remained the tool reports that rather than inventing one, because guessing a permission set is how you silently over-grant. ESTATE CONTEXT: 67 repositories and 100 workflow files are in this state. The most frequently broken file is workflow-linter.yml, in 22 repositories — the workflow whose job is to lint workflows was itself unparseable, so it never ran and never caught this. Detection is being added upstream so it cannot recur invisibly: a strict YAML loader in the governance reusable (hyperpolymath/standards#582). Ordinary validation cannot see this class of fault, because yaml.safe_load accepts duplicate keys and only a full parse catches the malformed indentation. EXPECT THIS REPOSITORY TO GET LOUDER. Workflows that have been failing silently will now actually run, and some will find real problems. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
1 parent d1c58ea commit cf812e3

5 files changed

Lines changed: 0 additions & 5 deletions

File tree

.github/workflows/ada.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ on:
88
branches: [ "main" ]
99

1010
permissions: read-all
11-
actions: read
1211

1312
jobs:
1413
build:

.github/workflows/codeql.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ concurrency:
1919

2020

2121
permissions: read-all
22-
actions: read
2322

2423
jobs:
2524
analyze:

.github/workflows/generator-generic-ossf-slsa3-publish.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ on:
1818
types: [created]
1919

2020
permissions: read-all
21-
actions: read
2221

2322
jobs:
2423
build:

.github/workflows/scorecard.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ on:
99
branches: [main]
1010

1111
permissions: read-all
12-
actions: read
1312

1413
jobs:
1514
analysis:

.github/workflows/workflow-linter.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ on:
1111
- '.github/workflows/**'
1212

1313
permissions: read-all
14-
actions: read
1514

1615
jobs:
1716
lint-workflows:

0 commit comments

Comments
 (0)