custom user excmds that take arguments

[peff]

If I add a custom excmd like this in glide.ts:

glide.excmds.create({name: "foo", description: "bar"},
                    ({ args_arr }) => { console.log("foo: ", args_arr) });

I'd expect to be able to type :foo arg1 arg2 and for my function to see both arguments. But I don't. It always gets an empty array.

The tests have something similar in

glide/src/glide/browser/base/content/test/excmds/browser_excmds.ts

Lines 237 to 241 in 107e240

	await GlideTestUtils.reload_config(function _() {
	glide.excmds.create({ name: "test_command", description: "Test command" }, ({ args_arr }) => {
	glide.g.value = args_arr;
	});
	});

and it works there. But I think that is only because it is exercised a few lines below by calling api.excmds.execute("test_command arg1 arg2") directly.

When the user actually types it, we end up processing a commandline_accept excmd that eventually takes us to here:

glide/src/glide/toolkit/content/widgets/glide-commandline.ts

Lines 348 to 362 in 107e240

	case "excmd": {
	var command: string;
	if (this.#last_action === "switch-focus") {
	// if the last thing the user did was switch from one completion to another, e.g. with `<Tab>` or `<S-Tab>`
	// then we should use the focused row as thats what would be expected.
	command = this.#get_excmd_from_row(row);
	} else {
	command = this.#get_input()!.value;
	// if the input isn't a valid command then we should use the focused row as the input was likely only used
	// to filter out completions, e.g. input `conf` to get `config` as the focused row.
	if (!GlideExcmds.is_known_command(command)) {
	command = this.#get_excmd_from_row(row);
	}
	}

. Because is_known_command() doesn't return true, we discard the input arguments. And that function only checks the list of built-in excmds. So doing :tab_new https://example.com works (because it is a known command), but a custom excmd to do the same thing does not. So I think the bug may just be that is_known_command() should take into account user excmds?

[RobertCraigie]

Thank you for the detailed bug report and investigating the root cause! I really appreciate it.

I can reproduce and confirm that your suggested fix works, will push a fix for this in the next release.

side note that I really need to get rid of the difference between user defined excmds and builtin ones, it's a hack really.

[RobertCraigie]

Fixed in 81e21d0, thank you again for the brilliant report!

[peff]

Thanks for the quick turnaround! I can confirm that it works as expected now. The fix and test are exactly along the lines I'd imagined (sorry for not producing them myself, but being new to the code base I wasn't quite sure of the exact incantations).