F does not always open a new tab

[imnotpoz]

$ glide --version
Glide glide 0.1.56a

~/.config/glide/glide.ts:

glide.o.hint_size = "20px";
glide.o.hint_chars = "neioarstgmjluyqwfpbkhzxcdv";
glide.keymaps.set("normal", "<leader>cr", "config_reload");
glide.keymaps.set("normal", "<leader>cl", "clear");
glide.keymaps.set("normal", "<leader>ce", function() {
    glide.process.execute("foot", ["nvim", "glide.ts"], { cwd: "~/.config/glide" });
});

glide.addons.install("https://addons.mozilla.org/firefox/downloads/file/4629131/ublock_origin-1.68.0.xpi");
glide.addons.install("https://addons.mozilla.org/firefox/downloads/file/4638146/darkreader-4.9.118.xpi");
glide.addons.install("https://addons.mozilla.org/firefox/downloads/file/4628286/keepassxc_browser-1.9.11.xpi");

using F always opens the link I want to follow but at times it does it in the currently active tab

not sure what causes this but it happens on github most often

[RobertCraigie]

Thanks for the report, do you have a specific example where this happens? Or is it inconsistent?

[imnotpoz]

I can consistently get it on the readme links leading to the same repository on github

[RobertCraigie]

I couldn't repro but opened #202 which should fix it anyway

[suveshmoza]

I was able to repro it on Glide Readme and certain pages. It seems to be happening on href with relative urls or clicks being intercepted by scripts on pages.

Steps to repro:

1. Scroll down to Contributing on Glide's readme.
2. Press `F`, select LICENSE and it will be opened in the current tab. 

[suveshmoza]

@imnotpoz For now, you can add these lines to your Glide config. This should give you the correct F behavior.

glide.keymaps.set('normal', 'F', () => {
    glide.hints.show({
        selector: '[href]',
        async action({ content }) {
            const href = await content.execute((target) => (target as HTMLAnchorElement).href);
            await browser.tabs.create({ url: href, active: false });
        },
    });
});

[imnotpoz]

I added a bit of really ugly code to this that makes it open in the next tab instead of the last, as well as makes the new one active:

declare global {
  interface GlideGlobals {
    current_tab_index: number;
  }
}

glide.g.current_tab_index = 0;

glide.autocmds.create("UrlEnter", { hostname: ".*" }, async ({ tab_id }) => {
    glide.g.current_tab_index = (await browser.tabs.get(tab_id)).index;
});

// https://github.com/glide-browser/glide/discussions/165#discussioncomment-15455999
glide.keymaps.set('normal', 'F', () => {
    glide.hints.show({
        selector: '[href]',
        async action({ content }) {
            const href = await content.execute((target) => (target as HTMLAnchorElement).href);
            await browser.tabs.create({ url: href, active: true, index: glide.g.current_tab_index + 1 });
        },
    });
});

[imnotpoz]

ok sorry it doesn't actually always work 😭

[suveshmoza]

Try this

glide.keymaps.set('normal', 'F', async () => {
    const tabs = await browser.tabs.query({ active: true, currentWindow: true });
    const currTabIdx = tabs[0]?.index;

    const nextTabIndex = currTabIdx != undefined ? currTabIdx + 1 : undefined;

    glide.hints.show({
        selector: '[href]',
        async action({ content }) {
            const href = await content.execute((target) => (target as HTMLAnchorElement).href);
            await browser.tabs.create({
                url: href,
                active: true,
                index: nextTabIndex,
            });
        },
    });
});

[imnotpoz]

that works thank you so much!!!!! :3c