Random collection of API changes we should do for 14.X.X
SourceBundleWriter:
finish should return back the Writer- API duplication for
write_object* should probably be a single function
- Consider shrinking the API surface and moving all settings which are only necessary for
write_object into a arguments struct that is passed into write object.
symbolic-ppdb:
EmbeddedSource::get_contents_bounded can be renamed to get_contents, the old get_contents removed.- The sole field of
FormatErrorKind::InvalidBlobFormat should have type i32 instead of u32.
CfiCache:
- Cleanup the API around
from_object_with_opts instead use some builder pattern that allows us to provide the options.
- Variables/
symbolic_debuginfo::base
- Consider moving some of the types in
base.rs into a module and namespacing it like all (variable-)types and potentially more variable related types.
Random collection of API changes we should do for 14.X.X
SourceBundleWriter:finishshould return back theWriterwrite_object*should probably be a single functionwrite_objectinto a arguments struct that is passed intowrite object.symbolic-ppdb:EmbeddedSource::get_contents_boundedcan be renamed toget_contents, the oldget_contentsremoved.FormatErrorKind::InvalidBlobFormatshould have typei32instead ofu32.CfiCache:from_object_with_optsinstead use some builder pattern that allows us to provide the options.symbolic_debuginfo::basebase.rsinto a module and namespacing it like all (variable-)types and potentially more variable related types.