Skip to content

Commit 6c05600

Browse files
committed
fix(privacy): scrub client name + private memory-file slugs the first pass missed
The audit found two gaps the original marker list did not cover: - A client name (WAGMI) was live on main in step-2/ghostty-install.sh and CHANGELOG.md, naming that client's team as the people who hit an install bug. The CHANGELOG entry also cited a private memory-file slug. - Six references to private memory-file slugs (feedback_*/reference_*) sat inside skills the installers write to a recipient's ~/.claude/skills/ — pointing a stranger's assistant at a memory store it has no access to, and disclosing the naming of that store. Replaced all of them with the plain-English rule they were citing, which is what a recipient can actually act on. The gate's private marker list (held outside this repo, per scripts/check-pii.sh) gained the full client/project roster plus a memory-slug pattern, so both classes now fail the build. The user_ prefix is deliberately excluded from that pattern: it collides with 'user_invocable' skill frontmatter.
1 parent 2812e8a commit 6c05600

5 files changed

Lines changed: 8 additions & 8 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
4646
- Step 6 — Telegram bot token file is written inside a `umask 077` subshell so it is born `0600` (no permissive-umask window before the chmod).
4747
- Step 7 — corrected the comment that claimed the GitHub PAT is "never in `ps` output" (it is briefly visible in the local process list while `claude mcp add` runs; behavior unchanged, comment now truthful).
4848
- README — uninstall "what gets removed" list no longer claims ffmpeg (creativity-maxxing installs and removes it; ten lines up the same section already said so).
49-
- Step 2 (`step-2/ghostty-install.sh`): post-install summary now includes a yellow "ONE MORE STEP — GRANT FULL DISK ACCESS" section with click-by-click instructions (System Settings → Privacy & Security → Full Disk Access → toggle Ghostty ON, with the `+``/Applications` fallback if Ghostty isn't listed). New `--open-fda` flag jumps directly to the right pane via the canonical `x-apple.systempreferences:...?Privacy_AllFiles` URL. Closes item 1 of the WAGMI Apr-22 install-call bug catalog (`project_wagmi_install_bugs_2026_04_22.md`) — every WAGMI teammate hit silent FDA-permission errors on first launch.
49+
- Step 2 (`step-2/ghostty-install.sh`): post-install summary now includes a yellow "ONE MORE STEP — GRANT FULL DISK ACCESS" section with click-by-click instructions (System Settings → Privacy & Security → Full Disk Access → toggle Ghostty ON, with the `+``/Applications` fallback if Ghostty isn't listed). New `--open-fda` flag jumps directly to the right pane via the canonical `x-apple.systempreferences:...?Privacy_AllFiles` URL. Closes item 1 of the Apr-22 install-call bug catalog — every tester hit silent FDA-permission errors on first launch.
5050
- Step 1-5 — anchored MCP grep patterns at `^<name>:` so substring matches don't trigger false-positive "already installed" detection.
5151
- Step 5 — BSD grep compat fix in Motion detection (macOS `grep` doesn't support `-P` like GNU does; pattern simplified accordingly).
5252
- Step 6 — `SAVED_TOKEN` env var unset after self-test validation so a stale value doesn't leak into the next step.

landing-ab-skill/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Every landing page ships able to watch, test, and rebuild itself. No more frozen
3131
}
3232
})
3333
```
34-
4. **Light mode default** — never ship `prefers-color-scheme: dark` as default (standing rule `feedback_never_dark_mode`).
34+
4. **Light mode default** — never ship `prefers-color-scheme: dark` as default.
3535
5. **Drop `docs/LP-OPS.md`** into the repo (see template below) so the optimization loop survives the session.
3636

3737
Division of labor: `copywriting` owns the words, `high-end-visual-design` / `ui-ux-pro-max` own the look — this skill owns instrumentation + the optimization loop.

osmani-build-skill/SKILL.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ allowed-tools: Skill, Bash, Read, Grep, Task, Agent
1818

1919
Thin orchestrator. The addy plugin skills do the actual work; this skill decides WHICH of the 24
2020
fire, in what order, with your house rules overriding addy's defaults. Born 2026-07-02, same day
21-
the plugin landed (`reference_addy_agent_skills_plugin.md`).
21+
the plugin landed.
2222

2323
## When this fires — OFFER, never auto-run
2424

@@ -73,9 +73,9 @@ Default momentum is continue; a bare "go" advances. Never re-litigate a complete
7373
PR-flow steps inside git-workflow-and-versioning.
7474
- **Never** `Co-Authored-By: claude-flow <ruv@ruv.net>` or any ruv* coauthor on commits.
7575
- **No proactive docs/READMEs.** documentation-and-adrs runs only on explicit ask; READMEs follow
76-
`feedback_readme_style` (personal voice, no dev-jargon jokes).
76+
README style: personal voice, no dev-jargon jokes.
7777
- **ADRs route through /save branch 4**`Claude-Memory/adr/ADR-<nnn>-<slug>.md`, not addy's location.
78-
- **Never dark mode by default** on any scaffold (`feedback_never_dark_mode`).
78+
- **Never dark mode by default** on any scaffold.
7979
- **Task creation → /maketasks.** Any planning output that becomes tracked tasks goes through the
8080
skill — never direct 05-Tasks writes, never minted UUIDs.
8181
- **/recon stays separate** — this skill never runs the landscape sweep itself.
@@ -87,7 +87,7 @@ Default momentum is continue; a bare "go" advances. Never re-litigate a complete
8787
`ls ~/.claude/plugins/cache/addy-agent-skills/agent-skills/*/skills/<name>/SKILL.md`
8888
(version dir changes on plugin update — always glob, never hardcode).
8989
3. Plugin missing entirely? Reinstall with the SSH→HTTPS workaround in
90-
`reference_addy_agent_skills_plugin.md`, then continue.
90+
the plugin's own docs, then continue.
9191

9292
## Non-goals
9393

recon-skill/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ allowed-tools: Bash, WebSearch, WebFetch, Read, Write, Task, Agent
66

77
# recon — look before you build
88

9-
The rule (memory `feedback_prior_art_check_before_building`): **prior-art sweep BEFORE code, not after.** talk2me is the scar — a whole hands-free voice loop for Claude Code built and shipped before discovering `mbailey/voicemode` (MIT, ~1.2k★) does nearly the same thing and Anthropic ships native `/voice`. The check belongs at turn one.
9+
The rule: **prior-art sweep BEFORE code, not after.** talk2me is the scar — a whole hands-free voice loop for Claude Code built and shipped before discovering `mbailey/voicemode` (MIT, ~1.2k★) does nearly the same thing and Anthropic ships native `/voice`. The check belongs at turn one.
1010

1111
This skill produces a **ranked landscape + edge analysis + GREEN/YELLOW/RED verdict**. It does NOT build. Building starts only after the discussion.
1212

step-2/ghostty-install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ print_summary() {
497497
# -------------------------------------------------------------------------
498498
# ONE MORE STEP — Full Disk Access (macOS only)
499499
# Ghostty silently fails to read most user files until macOS grants it
500-
# Full Disk Access. Every WAGMI teammate hit this on their first install.
500+
# Full Disk Access. Every tester hit this on their first install.
501501
# Print exact click-by-click instructions; menu names verified against
502502
# macOS Sonoma / Sequoia (post-Ventura it's "System Settings", not
503503
# "System Preferences").

0 commit comments

Comments
 (0)