Applying a Gradle "plugin" via including a script (i.e. apply("some file") is frowned upon for a variety of reasons, including the lack of versioning, lack of dependency management (i.e. locking, or hosting in your own repository), and making build script compilation avoidance harder.
I don't see anything in your settings script that would be impossible to do via a settings plugin. For that matter, I don't see what value the settings plugin provides - it's easier and much better practice to just add the build plugin yourself.
Applying a Gradle "plugin" via including a script (i.e.
apply("some file")is frowned upon for a variety of reasons, including the lack of versioning, lack of dependency management (i.e. locking, or hosting in your own repository), and making build script compilation avoidance harder.I don't see anything in your settings script that would be impossible to do via a settings plugin. For that matter, I don't see what value the settings plugin provides - it's easier and much better practice to just add the build plugin yourself.