fix: address review comments on _update_submission

Author: dconstancy

compute_worker/compute_worker.py

@@ -8,7 +8,6 @@
 import signal
 import socket
 import tempfile
-import random
 import time
 import uuid
 import requests
@@ -504,10 +503,10 @@ def __init__(self, run_args):
         self.requests_session = requests.Session()
         adapter = requests.adapters.HTTPAdapter(
             max_retries=Retry(
-                total=5,
-                backoff_factor=2,
+                total=3,
+                backoff_factor=1,
                 status_forcelist=[502, 503, 504],
-                allowed_methods=["PATCH", "GET", "PUT", "POST"],
+                allowed_methods=["PATCH", "GET", "PUT"],
             )
         )
         self.requests_session.mount("http://", adapter)
@@ -617,36 +616,20 @@ def _get_stdout_stderr_file_names(self, run_args):
             ]
         return [run_args[name] for name in DETAILED_OUTPUT_NAMES]
 
-    def _update_submission(self, data, max_retries=5, backoff_base=2):
+    def _update_submission(self, data):
         url = f"{self.submissions_api_url}/submissions/{self.submission_id}/"
         data["secret"] = self.secret
 
-        for attempt in range(1, max_retries + 1):
-            logger.info(f"Updating submission @ {url} (attempt {attempt}/{max_retries}) with data = {data}")
-            try:
-                resp = self.requests_session.patch(url, data=data, timeout=150)
-            except requests.exceptions.RequestException as exc:
-                logger.warning(f"Submission patch request failed (attempt {attempt}/{max_retries}): {exc}")
-                if attempt == max_retries:
-                    raise SubmissionException(f"Failure updating submission data after {max_retries} attempts.")
-                sleep_s = backoff_base ** attempt + random.uniform(0, 1)
-                logger.info(f"Retrying in {sleep_s:.1f}s...")
-                time.sleep(sleep_s)
-                continue
-
-            if resp.status_code == 200:
-                logger.info("Submission updated successfully!")
-                return
-            else:
-                logger.warning(
-                    f"Submission patch failed (attempt {attempt}/{max_retries}) "
-                    f"with status = {resp.status_code}, and response = \n{resp.content}"
-                )
-                if attempt == max_retries:
-                    raise SubmissionException(f"Failure updating submission data after {max_retries} attempts.")
-                sleep_s = backoff_base ** attempt + random.uniform(0, 1)
-                logger.info(f"Retrying in {sleep_s:.1f}s...")
-                time.sleep(sleep_s)
+        logger.info(f"Updating submission @ {url}")
+
+        resp = self.requests_session.patch(url, data=data, timeout=150)
+        if resp.status_code == 200:
+            logger.info("Submission updated successfully!")
+        else:
+            logger.error(
+                f"Submission patch failed with status = {resp.status_code}, and response = \n{resp.content}"
+            )
+            raise SubmissionException("Failure updating submission data.")
 
     def _update_status(self, status, extra_information=None):
         # Update submission status
@@ -658,6 +641,7 @@ def _update_status(self, status, extra_information=None):
         try:
             self._update_submission(data)
         except Exception as e:
+            # Re-raise only for terminal statuses so Celery marks the task as failed.
             logger.exception(f"Failed to update submission status to {status}: {e}")
             if status in ("Finished", "Failed"):
                 raise