Skip to content

deal with phylo data more elegantly #18

Description

@JenkeScheen

in cases like SARS-CoV-2 N protein we have to use phylogenetics data. Two issues:

  • this is formatted at JSON, we do have a standalone script for the conversion already but this should be absorbed into API (see https://github.com/asapdiscovery/choppa/blob/main/choppa/IO/convert.py)
  • specifically for N protein (but will happen in future for other targets too) the PDB is a homodimer. The fitness data (in JSON) is as monomer, so we need to duplicate the fitness data to make sure the alignment works correctly.

For the second point, I had a go (in IO) by making a copy of the fitness DF, then adjusting the residue index column in the copy to start counting from where the first fitness DF ended, and then concatenating both DFs together: this messes up the alignment spectacularly.

Perhaps a more elegant approach would be to align the whole phylogenetics JSON to the PDB, then pick the largest overlapping island? Would still have to deal with mini gaps (may just need to define some lag factor). This wouldn't solve the homodimer issue though - perhaps this could just be exposed in the CLI and then a duplication as above is tried?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions