From 93ba920e1826d30c0e9f221ed3fc96afbc3e1ac5 Mon Sep 17 00:00:00 2001
From: Nicolas Iooss <nicolas.iooss_git@polytechnique.org>
Date: Mon, 13 Apr 2026 09:59:01 +0000
Subject: [PATCH] fix compatibility issue with NumPy>=2.4.0

When using recent NumPy, `nsec3hash.py` fails with:

                    sol = int(self.solutions[i])
                          ~~~^^^^^^^^^^^^^^^^^^^
    TypeError: only 0-dimensional arrays can be converted to Python scalars

This comes from a change from NumPy 2.4.0, documented in
https://numpy.org/devdocs/release/2.4.0-notes.html#raise-typeerror-on-attempt-to-convert-array-with-ndim-0-to-scalar

> Raise `TypeError` on attempt to convert array with `ndim > 0` to scalar
>
> Conversion of an array with `ndim > 0` to a scalar was deprecated in
> NumPy 1.25. Now, attempting to do so raises `TypeError`. Ensure you
> extract a single element from your array before performing this
> operation.

As `self.solutions` is a NumPy array with shape `(self.max_nholes, 1)`,
adding `[0]` fixes this issue. Add `[0]` in other places as well, to
make the code more robust to future NumPy changes.
---
 nsec3hash.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/nsec3hash.py b/nsec3hash.py
index 4f10c04..abdf5ce 100755
--- a/nsec3hash.py
+++ b/nsec3hash.py
@@ -325,28 +325,28 @@ def match_hashes(self, holes, pbar=None, finish=None, bl=None):
             i = 0
             copied = False
             while i < nholes:
-                if self.solutions[i] == -1:
+                if self.solutions[i][0] == -1:
                     i+=1
                 else:
-                    #print("solve ", i, self.solutions[i])
+                    #print("solve ", i, self.solutions[i][0])
                     if not copied:
                         cl.enqueue_copy(self.clhash.queue, self.clhash.in_data, self.clhash.in_data_cl).wait()
                         copied=True
-                    sol = int(self.solutions[i])
+                    sol = int(self.solutions[i][0])
                     #print((hex(self.holes[i][0]), hex(self.holes[i][1]), self.clhash.get_data(self.data_max_len, sol), self.clhash.get_hash(sol).hex()))
                     fqdn = antihash(self.clhash.get_data(self.data_max_len, sol))
                     if bl and fqdn in bl:
                         # fqdn is blocked, don't append it
                         print(f"Skip blocked fqdn {fqdn}")
                         # mark it as bad in cl memory so we don't hit on it on next iteration
-                        self.solutions[i] = -1
+                        self.solutions[i][0] = -1
                         cl.enqueue_copy(self.clhash.queue, self.solutions_cl, self.solutions)
                         i += 1
                         continue
                     solved.append([self.holes[i][0], self.holes[i][1], fqdn])
                     nholes -= 1
                     self.holes[i] = self.holes[nholes]
-                    self.solutions[i] = self.solutions[nholes]
+                    self.solutions[i][0] = self.solutions[nholes][0]
                     self.holes[nholes] = [0, 0]
             avg, maxi = self.avg_holes_complexity(nholes)
             hashrate=calc_hashrate(start, self.nthreads)