Skip to content

Commit 132ec4f

Browse files
authored
Fix Variable.set rewriting team_name of existing variables (#71823)
1 parent 089ec00 commit 132ec4f

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

airflow-core/src/airflow/models/variable.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,6 @@ def set(
287287
val=val,
288288
description=description,
289289
is_encrypted=is_encrypted,
290-
team_name=team_name,
291290
)
292291
stmt = build_upsert_stmt(
293292
get_dialect_name(session), Variable, ["key"], upsert_values, update_fields

airflow-core/tests/unit/models/test_variable.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,14 @@ def test_masking_from_db(self, session):
369369
finally:
370370
session.rollback()
371371

372+
@conf_vars({("core", "multi_team"): "True"})
373+
def test_variable_set_does_not_change_team_name_on_update(self, testing_team, session):
374+
Variable.set(key="k", value="v1", session=session)
375+
376+
Variable.set(key="k", value="v2", team_name=testing_team.name, session=session)
377+
378+
assert Variable.get("k") == "v2"
379+
372380
@mock.patch("airflow.models.variable.ensure_secrets_loaded")
373381
def test_caching_caches(self, mock_ensure_secrets: mock.Mock):
374382
mock_backend = mock.Mock()

0 commit comments

Comments
 (0)