Contributing Margit Env

[faizankshaikh]

Hi - First off, great work! I learnt a lot from reading through the codebase.

I have been doing experiments for the Margit Env (Disclaimer - AI driven dev, bloated but working branch ). I believe a few days of work would make it viable for a PR. But before that, lets have a discussion of expectations so that the PR is aligned with the current codebase

[amacati]

Hey, super cool to see that you tried it out! And thanks for the AI disclaimer, the honesty is much appreciated.

I am very much open to including Margit. If Elden Ring has not changed dramatically from the last time I touched the project, the path towards including it should be pretty straightforward. I assume you can already launch the environment on your side?

As one might guess from skipping through the code, this project was supposed to be as clean as possible, and I would like to keep it that way. So several things in the code like the dummy attributes the agent generated (e.g. allow_attacks) would have to be cleaned up. It should avoid any kind of defensive programming, i.e. things that are not supported or not implemented should fail, and they should do so immediately. Then there are some things that seem to have changed between Dark Souls and Elden Ring, like the animation IDs. It would be great if you could give me a rundown of what is different between the two, particularly animation handling etc, so that we can design a clean solution that scales to more bosses.

You could clean up some of the development files (agent.md files, development documentation) and then open a PR we can iterate on, or you can send me an email and we can discuss things in a brief meeting. In any case, it would be awesome to revive the project and add proper Elden Ring support!

[faizankshaikh]

Hey!

I am very much open to including Margit.

Perfect - I will let you know when I'm ready with the PR

If Elden Ring has not changed dramatically from the last time I touched the project, the path towards including it should be pretty straightforward. I assume you can already launch the environment on your side?

It hasnt changed much. I am able to run the env and make the agent do actions, but at the moment its quite buggy and there are a lot of edge cases to deal with

As one might guess from skipping through the code, this project was supposed to be as clean as possible, and I would like to keep it that way

Completely agree. It is in my agenda to clean up the bloat and make a PR that is humanly possible to review

It would be great if you could give me a rundown of what is different between the two, particularly animation handling etc, so that we can design a clean solution that scales to more bosses.

Yes, I would also like to extend the contribution to more envs like Malenia, so I will make it robust and have clear documentation

You could clean up some of the development files (agent.md files, development documentation) and then open a PR we can iterate on, or you can send me an email and we can discuss things in a brief meeting.

Will do. I would like to take it slow, make sure it works before creating the PR. It could take a few days to few weeks, but I'm pretty sure it should be manageable now that I am over the difficult parts of the project

---

What actually got me interested in the repo is log analytics of the gameplay data I think it would be quite useful for hitless / challenge runners, and not just RL agents. We can decide later if this is something worth considering as part of this repo or a separate fork, once the core Env is in place.

Loading: ..\logs\observer\ai_unpaused_observe_20260709_174627.json
Steps: 322  |  Status: player_death_stop  |  Runtime: 0:01:04

[amacati]

Perfect, looking forward to your PR. Regarding the analytics of gameplay data: the current separation into envs and game interfaces in Python already allows you to use parts of the library purely for logging. If you mean there should be dedicated speedrun modes, then that's something we would have to discuss in more detail. I'm not generally against it, but want to make sure it fits well into the project