Skip to content

Roadmap algorithm - #125

Open
rprebet wants to merge 39 commits into
algebraic-solving:mainfrom
rprebet:roadmap
Open

Roadmap algorithm#125
rprebet wants to merge 39 commits into
algebraic-solving:mainfrom
rprebet:roadmap

Conversation

@rprebet

@rprebet rprebet commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

This PR brings functions to compute a roadmap for a smooth and bounded real algebraic set, together with query points.
This comes with a new optimized data structure for roadmaps and associated functions.
Substantial additional documentation is also included.

@mohabsafey

Copy link
Copy Markdown
Collaborator

Many thanks for all of this. As far as I understand, the roadmap function fails when a change of variables is needed which might be restrictive. Do you confirm?

@rprebet

rprebet commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

Do you suggest performing a random change of variables as soon/long as the roadmap function fails?
I'm ok with that.

@mohabsafey

Copy link
Copy Markdown
Collaborator

Sorry for the late reply. All apologies. Yes, I think that the change of variables should be done automatically. Also, note that this is needed only to ensure dimension properties. Hence, we could have these changes of variables chosen deterministically so that the function returns always the same roadmap for a given input (the output should not depend on the execution). This is how I do in raglib (you can have a look or I can show you).

@mohabsafey

Copy link
Copy Markdown
Collaborator

@rprebet do we plan to have deterministic linear changes of variables later (and then we could merge this PR) or have you already started this one?

@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 146 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.26%. Comparing base (29d66ba) to head (5e96453).
⚠️ Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
src/connectivity/roadmap.jl 0.00% 91 Missing ⚠️
src/connectivity/polar.jl 0.00% 32 Missing ⚠️
src/types.jl 0.00% 23 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   82.70%   76.26%   -6.44%     
==========================================
  Files          33       44      +11     
  Lines        3544     4660    +1116     
==========================================
+ Hits         2931     3554     +623     
- Misses        613     1106     +493     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants