Roadmap algorithm - #125
Conversation
|
Many thanks for all of this. As far as I understand, the roadmap function fails when a change of variables is needed which might be restrictive. Do you confirm? |
|
Do you suggest performing a random change of variables as soon/long as the roadmap function fails? |
|
Sorry for the late reply. All apologies. Yes, I think that the change of variables should be done automatically. Also, note that this is needed only to ensure dimension properties. Hence, we could have these changes of variables chosen deterministically so that the function returns always the same roadmap for a given input (the output should not depend on the execution). This is how I do in raglib (you can have a look or I can show you). |
|
@rprebet do we plan to have deterministic linear changes of variables later (and then we could merge this PR) or have you already started this one? |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 82.70% 76.26% -6.44%
==========================================
Files 33 44 +11
Lines 3544 4660 +1116
==========================================
+ Hits 2931 3554 +623
- Misses 613 1106 +493 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This PR brings functions to compute a roadmap for a smooth and bounded real algebraic set, together with query points.
This comes with a new optimized data structure for roadmaps and associated functions.
Substantial additional documentation is also included.