[mediawiki-api] FileUploader::upload() should return full response

[samwilson]

It's not currently possible to retrieve any warnings that are returned by the upload API.

It currently does this:

$response = $this->api->postRequest( new SimpleRequest( 'upload', $params ) );
return ( $response['upload']['result'] === 'Success' );

I'm trying to catch duplicate uploads (for T269518), but at the moment it's just false for anything amiss.

[addshore]

Do you have a suggested response instead?
Boolean true, false on some error and list of string on specific error?
Could also add a generic Action api looking error object? or throw something?

[samwilson]

I was wondering about either a new parameter to upload() (e.g. $getFullResponse) or a new method e.g. uploadWithResponse(). I sort of think the latter might be clearer. Or another way: save the response in a member variable and add a new getUploadResponse() method for retrieving it. What do you think?

Or is it better, as you say, to throw specific things. In my case, it'd be fine to just be catching a DuplicateFileWarningException, but I'm not sure we'd want to have to keep handling all different possible warnings like that (I don't know how many there are).