Skip to content

should-have-complete-templates false positive on a well-formed template (page-sidebar.html) #84

Description

@markrusselldev

Reporting this for the feedback requested in the informational Trac comments.

On my theme's review (Trac #284094, theme Blockwright), the tool reported:

There's a problem with templates in: /templates/page-sidebar.html
See: ui-errors.md#should-have-complete-templates

The docs say this check verifies that all tags have closing tags and are properly formed. This template looks well-formed: every block comment and HTML tag is balanced, and the sidebar template part it references is balanced too. Automated Theme Check on the same upload passed with 0 required issues. So I believe it is a false positive, but tell me if I am missing something.

The flagged template (templates/page-sidebar.html):

<!-- wp:template-part {"slug":"header","area":"header","tagName":"header"} /-->

<!-- wp:group {"tagName":"main","align":"full","layout":{"type":"constrained"},"metadata":{"name":"Main"}} -->
<main class="wp-block-group alignfull">
  <!-- wp:columns {"align":"wide","style":{"spacing":{"blockGap":{"left":"var:preset|spacing|x-large"}}}} -->
  <div class="wp-block-columns alignwide">
    <!-- wp:column {"width":"66.66%"} -->
    <div class="wp-block-column" style="flex-basis:66.66%">
      <!-- wp:group {"layout":{"type":"constrained"}} -->
      <div class="wp-block-group">
        <!-- wp:post-title /-->
        <!-- wp:post-content /-->
      </div>
      <!-- /wp:group -->
    </div>
    <!-- /wp:column -->
    <!-- wp:column {"width":"33.33%"} -->
    <div class="wp-block-column" style="flex-basis:33.33%">
      <!-- wp:template-part {"slug":"sidebar","tagName":"aside"} /-->
    </div>
    <!-- /wp:column -->
  </div>
  <!-- /wp:columns -->
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer","area":"footer","tagName":"footer"} /-->

I can share the full theme or the sidebar part if that helps.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions