apply suggestions from code review (WP-976)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: vsolovei-smartling

inc/Smartling/Bootstrap.php

@@ -438,7 +438,7 @@ private function initializeBuildInContentTypes(ContainerBuilder $di): void
                 'smartling-react-app',
                 plugin_dir_url(__FILE__) . '../../js/app.js',
                 ['wp-element', 'wp-components', 'wp-date'],
-                static::$pluginVersion . random_int(0, 10000),
+                static::$pluginVersion,
                 true,
             );
             wp_enqueue_style('wp-components');

inc/Smartling/WP/Controller/ContentEditJobController.php

@@ -77,7 +77,7 @@ public function initJobApiProxy(): void
             $validateRequires = static function ($fieldName) use (&$result, $params) {
                 $value = trim($params[$fieldName]);
 
-                if (!array_key_exists($fieldName, $params) || $value !== '') {
+                if (!array_key_exists($fieldName, $params) || $value === '') {
                     $msg = vsprintf('The field \'%s\' cannot be empty', [$fieldName]);
                     Bootstrap::getLogger()->warning($msg);
                     $result['status'] = 400;

inc/Smartling/WP/View/BulkSubmit.php

@@ -65,7 +65,7 @@
              data-bulk-submit="true"
              data-content-type=""
              data-content-id="0"
-             data-locales='<?= json_encode(array_values($localesData)) ?>'
+             data-locales='<?= htmlspecialchars(json_encode(array_values($localesData), JSON_HEX_APOS | JSON_HEX_QUOT | JSON_HEX_AMP | JSON_HEX_TAG), ENT_QUOTES, 'UTF-8') ?>'
              data-ajax-url="<?= admin_url('admin-ajax.php') ?>"
              data-admin-url="<?= admin_url('admin-ajax.php') ?>"></div>
         <div class="postbox-container" style="display:none;">

inc/Smartling/WP/View/ContentEditJob.php

@@ -58,7 +58,7 @@
                  data-bulk-submit="false"
                  data-content-type="<?= $data['contentType'] ?? $baseType ?>"
                  data-content-id="<?= $id ?>"
-                 data-locales='<?= json_encode(array_values($localesData)) ?>'
+                 data-locales='<?= htmlspecialchars(json_encode(array_values($localesData), JSON_HEX_APOS | JSON_HEX_QUOT), ENT_QUOTES, 'UTF-8') ?>'
                  data-ajax-url="<?= admin_url('admin-ajax.php') ?>"
                  data-admin-url="<?= admin_url('admin-ajax.php') ?>"></div>
 <?php if ($needWrapper) : ?>

js/app.js

@@ -149,13 +149,16 @@ function JobWizard({ isBulkSubmitPage, contentType, contentId, locales, ajaxUrl,
                     }
                 });
 
-                if (jobResponse.status > 300) {
+                if (jobResponse.status >= 400) {
                     throw new Error(jobResponse.message?.global || 'Failed to create job');
                 }
                 data.job.id = jobResponse.data.translationJobUid;
             }
 
-            await jQuery.post(url, data);
+            const submissionResponse = await jQuery.post(url, data);
+            if (submissionResponse.status && submissionResponse.status > 300) {
+                throw new Error(submissionResponse.message?.global || 'Failed to add content to upload queue.');
+            }
             setSuccess('Content successfully added to upload queue.');
         } catch (e) {
             setError(e.message || 'Failed adding content to upload queue.');