add photo credt localization

Author: rzach

locale/LOCALIZATION.md

@@ -61,6 +61,12 @@ of the file, e.g.,
 \olfileid[fr]{sfr}{siz}{int}
 ```
 
+If you include photos from the [OLP photo
+repository](https://github.com/OpenLogicProject/photos), you should
+translate the photo credit files in
+`assets/photos/<name>/<name>-credit.tex` and put those into a (new)
+directory `locale/fr/photocredits.
+
 To prepare translations of textbooks, e.g., [_Set
 Theory_](https://github.com/OpenLogicProject/set-theory), put the
 contents of the corresponding repository in `locale/fr/courses/`. To

open-logic-locale.sty

@@ -56,6 +56,7 @@
 
 \addto\extrasenglish{
 % execute whenever the language switches to English
+\Crefname{page}{p.}{pp.}
 \Crefname{thm}{Theorem}{Theorems}
 \Crefname{ex}{Example}{Examples}
 \Crefname{defn}{Definition}{Definitions}
@@ -91,7 +92,7 @@
   \href{http://creativecommons.org/licenses/by/4.0/}{CC--BY}.}
 \newcommand*{\oluselicensetext}
   {It is based on
-  \textit{\href{\OLTlinktext}{\OLTname}}
+  \textit{\href{\OLTlinkname}{\OLTname}}
   by the
   \href{http://openlogicproject.org/}{\OLPname},
   used under a

sty/open-logic-referencing.sty

@@ -21,6 +21,7 @@
   % but not localized
   \IfNoValueT {#1}
     {\ifdefined\ollangid
+      \PackageWarning{open-logic}{File locale/\ollangid/\olfilebase\olfilename.tex requested but not marked \ollangid}
       \OLUnLocalizedHook{#1}
     \fi}}
 

sty/open-logic.sty

@@ -315,9 +315,17 @@
           \includegraphics[width=#1]{\olpath/assets/photos/#2/#2-small}}{
           \includegraphics[width=#1]{\olpath/assets/photos/#2/#2-large}}
         \caption{#3}
+        \label{photo-#2}
       \IfFileExists{\olpath/assets/photos/#2/#2-credit.tex}{%
+      \ifdefined\ollangid
+        \IfFileExists{\olpath/locale/\ollangid/photocredits/#2-credit.tex}{
+          \CatchFileDef{\photocredit}{\olpath/locale/\ollangid/photocredits/#2-credit.tex}{}%
+          \addtocontents{pcr}{#3, \cpageref{photo-#2}: \photocredit\par}}{
+          \PackageWarning{open-logic}{Photo credits \olpath/locale/\ollangid/photocredits/#2-credit.tex not found}}
+      \else
         \CatchFileDef{\photocredit}{\olpath/assets/photos/#2/#2-credit.tex}{}%
-        \addtocontents{pcr}{#3, p.~\thepage: \photocredit\par}}{}
+        \addtocontents{pcr}{#3, \cpageref{photo-#2}: \photocredit\par}
+      \fi}{}
 \end{wrapfigure}}}{}}
 
 % \olasset[width]{file} - include an illustration