Summary
The code-quality bot (CodeQL on #816) flags two "Inefficient String constructor" instances in src/it/java/dbProcs/GetterIT.java, inside testSSOAuthExistingUserRelogin():
String userName = new String("SSOReloginUser Lastname"); → String userName = "SSOReloginUser Lastname";String ssoName = new String("ssoreloginuser@example.com"); → String ssoName = "ssoreloginuser@example.com";
new String("literal") creates a redundant object; assign the literal directly. No behavior change, no new imports.
Severity
Trivial — test-only, micro-efficiency. Good first issue.
Acceptance criteria
Context
Surfaced while reviewing the code-quality bot output on #816. Out of scope for the connection-pooling work; filed as a standalone follow-up. Not a blocker for #816.
Summary
The code-quality bot (CodeQL on #816) flags two "Inefficient String constructor" instances in
src/it/java/dbProcs/GetterIT.java, insidetestSSOAuthExistingUserRelogin():String userName = new String("SSOReloginUser Lastname");→String userName = "SSOReloginUser Lastname";String ssoName = new String("ssoreloginuser@example.com");→String ssoName = "ssoreloginuser@example.com";new String("literal")creates a redundant object; assign the literal directly. No behavior change, no new imports.Severity
Trivial — test-only, micro-efficiency. Good first issue.
Acceptance criteria
new String("...")calls intestSSOAuthExistingUserRelogin()replaced with direct literal assignment.GetterITstill passes; code-quality alerts cleared.Context
Surfaced while reviewing the code-quality bot output on #816. Out of scope for the connection-pooling work; filed as a standalone follow-up. Not a blocker for #816.