Maintenance fork at NatLibFi

[juhoinkinen]

Omikuji is very important to one of the projects of the National Library of Finland, namely Annif. We have created a fork of Omikuji which we aim to maintain, mainly for our own use: https://github.com/NatLibFi/omikuji The PyPI project name for the fork is not yet decided.

So far we have migrated the CI pipeline to GitHub Actions, and will (probably, currently WIP) modernize the Python binding build system from milksnake to maturin.

We could use help with someone with more experience on Rust code.

(@tomtung please contact if you would like to discuss transferring the omikuji PyPI project or this GitHub repository to NatLibFi, or the maintenance status of Omikuji otherwise.)

[tomtung]

I'd be happy to add the NatLibFi account as maintainers for both the GitHub &PyPI projects, thanks for offering!

[juhoinkinen]

Great! I'll be offline next week, but I think @osma should be able to respond too. I'm not quite sure how organization accounts work in this kind of case, but anyway our PyPI org is https://pypi.org/org/NatLibFi/.

[osma]

@tomtung Thanks for your willingness to accept us as maintainers!

I also don't know exactly how this works, but for this GitHub project, I see two options:

1. Keep it as tomtung/omikuji, with us (a few individual NatLibFi employees) added as maintainers
2. Move it under the NatLibFi organization so it would become NatLibFi/omikuji (which is already the name of our fork, but in this case it would become the "official" home of omikuji, with GitHub performing automatic redirects from tomtung/omikuji to NatLibFi/omikuji)

I think we would prefer option 2, because in the long term, it would be cleaner to have this under our own GitHub organization where we can control repository settings, account/team access etc. on an organization level. But I completely understand if you want to keep it under your own account instead; it's your baby after all! In that case, we would probably work mostly on our own fork, not this original repo, and would mainly need to get maintainer access to the PyPI project "omikuji".

In any case we will of course ensure that your copyright statements are retained (which is required by the MIT license as well) and that the origin and history of the project is clear in the README and other documentation.

[tomtung]

Transferring to NatLibFi sounds good to me. I made an attempt and got error:

NatLibFi/omikuji already exists and You don’t have the permission to create public repositories on NatLibFi

So I think we need to remove the fork, and I also need permission to create public repo there?

[tomtung]

It doesn't seem like I can invite NatLibFi as a collaborator either. I got error:

No user found with that username. Try again.

[osma]

@tomtung Thanks for trying! Right, our fork uses that name right now and also you obviously don't have permissions to create repos on our org account. NatLibFi is a GitHub organization, not an individual user.

We will get back to you soon with a plan on how to do this, just need to do a bit of research first.

[juhoinkinen]

Yes, according to GH documentation essentially it is not possible to transfer a repository directly to an organization that one does belong as a member with owner permissions:

• To transfer a repository that you own to an organization, you must have permission to create a repository in the target organization.

So I propose to transfer the repo under my account, from where I then transfer it under @NatLibFi.

[juhoinkinen]

Seems the same would be needed for the PyPI project (first transfer it to me Edit: add me as a project collaborator with "owner" role: https://pypi.org/user/juhoinkinen/, and the I can transfer it to https://pypi.org/org/NatLibFi/):

The project can be transferred to any organization owned by the user. Teams within the organization will lose their collaboration permissions. Individual project owners and maintainers will retain their permissions.

[tomtung]

I attempted a GitHub repo transfer but got an error:

juhoinkinen/omikuji already exists

so I added @juhoinkinen and @osma as collaborators for now.

Also sent collaborator invite for the pypi project to @juhoinkinen.

[juhoinkinen]

I attempted a GitHub repo transfer but got an error:

juhoinkinen/omikuji already exists

Yeah, I did not remember it... sorry about that! I deleted my fork, and now the transfer should work. 🤞

[tomtung]

Done I think 👍

[juhoinkinen]

Yes, repo transfer under @NatLibFi is done! @tomtung's access is now set to "outside collaborator" with maintainment-level permissions.

I hope this attribution in README is ok: https://github.com/NatLibFi/omikuji/pull/61/changes

Also the PyPI project is transferred under NatLibFi: https://pypi.org/project/omikuji/ (with @tomtung as a maintainer).

Everything seems completed for the transfer? Thank you so much, @tomtung!