MDEV-40776 Atomic CREATE OR REPLACE silently breaks the foreign key

Give an error if one tries to drop a table referenced by a foreign keys
This is needed as innodb will keep the reference to the origina table
even when it is renamed to a temporary name as part of create or replace.

Other things:
- Changed the error message for  ER_TRUNCATE_ILLEGAL_FK to say
  "Cannot drop or truncate a table ..."

Author: montywi

mysql-test/main/create_or_replace.result

@@ -933,14 +933,19 @@ drop prepare stmt;
 create table t1 (x int primary key, y int) engine innodb;
 create table t2 (x int references t1(x)) engine innodb;
 create or replace table t1 (x int primary key);
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`x`) REFERENCES `test`.`t1` (`x`))
 create table t3 (x int);
 create or replace table t1 like t3;
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`x`) REFERENCES `test`.`t1` (`x`))
 create or replace table t1 select * from t3;
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`x`) REFERENCES `test`.`t1` (`x`))
 show create table t1;
 Table	Create Table
 t1	CREATE TABLE `t1` (
-  `x` int(11) DEFAULT NULL
-) ENGINE=MyISAM DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci
+  `x` int(11) NOT NULL,
+  `y` int(11) DEFAULT NULL,
+  PRIMARY KEY (`x`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci
 drop tables t3, t2, t1;
 # UNIQUE
 create table t1 (pk int auto_increment primary key, a varchar(2300), unique (a)) engine aria character set latin1;

mysql-test/main/create_or_replace.test

@@ -684,9 +684,12 @@ drop prepare stmt;
 --list_files $MYSQLD_DATADIR/test *sql*
 create table t1 (x int primary key, y int) engine innodb;
 create table t2 (x int references t1(x)) engine innodb;
+--error ER_TRUNCATE_ILLEGAL_FK
 create or replace table t1 (x int primary key);
 create table t3 (x int);
+--error ER_TRUNCATE_ILLEGAL_FK
 create or replace table t1 like t3;
+--error ER_TRUNCATE_ILLEGAL_FK
 create or replace table t1 select * from t3;
 show create table t1;
 drop tables t3, t2, t1;

mysql-test/main/trigger-trans.result

@@ -160,7 +160,7 @@ CREATE TRIGGER t1_ad AFTER DELETE ON t1 FOR EACH ROW SET @b = 1;
 SET @a = 0;
 SET @b = 0;
 TRUNCATE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`b`) REFERENCES `test`.`t1` (`a`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`b`) REFERENCES `test`.`t1` (`a`))
 SELECT @a, @b;
 @a	@b
 0	0

mysql-test/suite/atomic/create_fk.result

@@ -49,3 +49,51 @@ select * from t1;
 a	b	c
 1	1	1
 drop table t1;
+#
+# MDEV-40776 Atomic CREATE OR REPLACE silently breaks the foreign key
+#
+create table t1 (pk int primary key, a int) engine=InnoDB;
+create table t2 (pk int primary key, b int, foreign key(b) references t1(pk)) engine=InnoDB;
+insert into t1 values (1,10),(2,20);
+insert into t2 values (1,1),(2,2);
+create or replace table t1 (pk int primary key, a int) engine=InnoDB;
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`b`) REFERENCES `test`.`t1` (`pk`))
+select * from t1;
+pk	a
+1	10
+2	20
+select * from t2;
+pk	b
+1	1
+2	2
+show create table t2;
+Table	Create Table
+t2	CREATE TABLE `t2` (
+  `pk` int(11) NOT NULL,
+  `b` int(11) DEFAULT NULL,
+  PRIMARY KEY (`pk`),
+  KEY `b` (`b`),
+  CONSTRAINT `1` FOREIGN KEY (`b`) REFERENCES `t1` (`pk`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci
+set @@foreign_key_checks=0;
+create or replace table t1 (pk int primary key, a int) engine=InnoDB;
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`b`) REFERENCES `test`.`t1` (`pk`))
+select * from t1;
+pk	a
+1	10
+2	20
+select * from t2;
+pk	b
+1	1
+2	2
+show create table t2;
+Table	Create Table
+t2	CREATE TABLE `t2` (
+  `pk` int(11) NOT NULL,
+  `b` int(11) DEFAULT NULL,
+  PRIMARY KEY (`pk`),
+  KEY `b` (`b`),
+  CONSTRAINT `1` FOREIGN KEY (`b`) REFERENCES `t1` (`pk`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci
+set @@foreign_key_checks=default;
+drop table if exists t2, t1;

mysql-test/suite/atomic/create_fk.test

@@ -52,3 +52,28 @@ insert into t1 values (1,1,1);
 create or replace table t1 (a int primary key, b int, c int, g int, constraint d foreign key e (b) references t1 (a)) engine=innodb select 1 as a ,2 as b,3 as c;
 select * from t1;
 drop table t1;
+
+--echo #
+--echo # MDEV-40776 Atomic CREATE OR REPLACE silently breaks the foreign key
+--echo #
+
+create table t1 (pk int primary key, a int) engine=InnoDB;
+create table t2 (pk int primary key, b int, foreign key(b) references t1(pk)) engine=InnoDB;
+insert into t1 values (1,10),(2,20);
+insert into t2 values (1,1),(2,2);
+
+--error ER_TRUNCATE_ILLEGAL_FK 
+create or replace table t1 (pk int primary key, a int) engine=InnoDB;
+select * from t1;
+select * from t2;
+show create table t2;
+
+set @@foreign_key_checks=0;
+--error ER_TRUNCATE_ILLEGAL_FK
+create or replace table t1 (pk int primary key, a int) engine=InnoDB;
+select * from t1;
+select * from t2;
+show create table t2;
+set @@foreign_key_checks=default;
+drop table if exists t2, t1;
+

mysql-test/suite/innodb/r/foreign_key.result

@@ -1073,7 +1073,7 @@ INSERT INTO child SET a=1;
 ERROR 23000: Cannot add or update a child row: a foreign key constraint fails (`test`.`child`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `parent` (`a`))
 connection default;
 TRUNCATE TABLE parent;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`child`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`parent` (`a`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`child`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`parent` (`a`))
 DROP TABLE parent;
 ERROR 23000: Cannot delete or update a parent row: a foreign key constraint fails
 SET innodb_lock_wait_timeout=0;
@@ -1104,7 +1104,7 @@ ALTER TABLE parent FORCE, ALGORITHM=INPLACE;
 ALTER TABLE parent ADD COLUMN b INT, ALGORITHM=INSTANT;
 SET foreign_key_checks=ON;
 TRUNCATE TABLE parent;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`child`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`parent` (`a`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`child`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`parent` (`a`))
 ALTER TABLE parent FORCE, ALGORITHM=COPY;
 ALTER TABLE parent FORCE, ALGORITHM=INPLACE;
 RENAME TABLE parent TO transparent;

mysql-test/suite/innodb/r/innodb-truncate.result

@@ -7,7 +7,7 @@
 CREATE TABLE t1 (pk INT PRIMARY KEY) ENGINE=INNODB;
 CREATE TABLE t2 (fk INT NOT NULL, FOREIGN KEY (fk) REFERENCES t1 (pk)) ENGINE=INNODB;
 TRUNCATE TABLE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`fk`) REFERENCES `test`.`t1` (`pk`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`fk`) REFERENCES `test`.`t1` (`pk`))
 # Truncation of child should succeed.
 TRUNCATE TABLE t2;
 DROP TABLE t2;
@@ -32,15 +32,15 @@ TRUNCATE TABLE t2;
 TRUNCATE TABLE t3;
 SET @@SESSION.foreign_key_checks = 1;
 TRUNCATE TABLE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`fk`) REFERENCES `test`.`t1` (`pk`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`fk`) REFERENCES `test`.`t1` (`pk`))
 TRUNCATE TABLE t2;
 TRUNCATE TABLE t3;
 LOCK TABLES t1 WRITE;
 SET @@SESSION.foreign_key_checks = 0;
 TRUNCATE TABLE t1;
 SET @@SESSION.foreign_key_checks = 1;
 TRUNCATE TABLE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`fk`) REFERENCES `test`.`t1` (`pk`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`fk`) REFERENCES `test`.`t1` (`pk`))
 UNLOCK TABLES;
 DROP TABLE t3,t2,t1;
 SET @@SESSION.foreign_key_checks = @old_foreign_key_checks;
@@ -88,7 +88,7 @@ ERROR HY000: Can't create table `test`.`t3` (errno: 150 "Foreign key constraint
 ALTER TABLE t1 RENAME TO t3;
 ALTER TABLE t3 FORCE;
 TRUNCATE TABLE t3;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`f2`) REFERENCES `test`.`t3` (`f2`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`f2`) REFERENCES `test`.`t3` (`f2`))
 DROP TABLE t2, t3;
 #
 # MDEV-24861 Assertion `trx->rsegs.m_redo.rseg' failed

mysql-test/suite/innodb/r/innodb.result

@@ -2410,15 +2410,15 @@ SELECT * FROM t1;
 id
 1
 TRUNCATE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`id`) REFERENCES `test`.`t1` (`id`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`id`) REFERENCES `test`.`t1` (`id`))
 INSERT INTO t1 (id) VALUES (NULL);
 SELECT * FROM t1;
 id
 1
 2
 DELETE FROM t1;
 TRUNCATE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`id`) REFERENCES `test`.`t1` (`id`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`id`) REFERENCES `test`.`t1` (`id`))
 INSERT INTO t1 (id) VALUES (NULL);
 SELECT * FROM t1;
 id
@@ -2596,15 +2596,15 @@ ERROR 23000: Cannot delete or update a parent row: a foreign key constraint fail
 update t4 set a=2;
 ERROR 23000: Cannot add or update a child row: a foreign key constraint fails (`test`.`t4`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `t3` (`a`))
 truncate t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`t1` (`a`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`t1` (`a`))
 truncate t3;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t4`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`t3` (`a`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t4`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`t3` (`a`))
 truncate t2;
 truncate t4;
 truncate t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`t1` (`a`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`t1` (`a`))
 truncate t3;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t4`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`t3` (`a`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t4`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`t3` (`a`))
 drop table t4,t3,t2,t1;
 create table t1 (a varchar(255) character set utf8mb3,
 b varchar(255) character set utf8mb3,

mysql-test/suite/innodb/r/innodb_mysql.result

@@ -2449,7 +2449,7 @@ INSERT INTO t2 VALUES (3,2);
 SET AUTOCOMMIT = 0;
 START TRANSACTION;
 TRUNCATE TABLE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`t1_id`) REFERENCES `test`.`t1` (`id`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`t1_id`) REFERENCES `test`.`t1` (`id`))
 SELECT * FROM t1;
 id
 1
@@ -2461,7 +2461,7 @@ id
 2
 START TRANSACTION;
 TRUNCATE TABLE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`t1_id`) REFERENCES `test`.`t1` (`id`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`t1_id`) REFERENCES `test`.`t1` (`id`))
 SELECT * FROM t1;
 id
 1
@@ -2479,7 +2479,7 @@ id
 2
 COMMIT;
 TRUNCATE TABLE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`t1_id`) REFERENCES `test`.`t1` (`id`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`t1_id`) REFERENCES `test`.`t1` (`id`))
 SELECT * FROM t1;
 id
 1
@@ -2491,7 +2491,7 @@ id
 1
 2
 TRUNCATE TABLE t1;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`t1_id`) REFERENCES `test`.`t1` (`id`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `1` FOREIGN KEY (`t1_id`) REFERENCES `test`.`t1` (`id`))
 ROLLBACK;
 SELECT * FROM t1;
 id

mysql-test/suite/innodb/r/truncate_foreign.result

@@ -5,7 +5,7 @@ ON UPDATE CASCADE)
 ENGINE=InnoDB;
 INSERT INTO child SET a=1;
 TRUNCATE TABLE parent;
-ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`child`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`parent` (`a`))
+ERROR 42000: Cannot drop or truncate a table referenced in a foreign key constraint (`test`.`child`, CONSTRAINT `1` FOREIGN KEY (`a`) REFERENCES `test`.`parent` (`a`))
 TRUNCATE TABLE child;
 INSERT INTO child SET a=1;
 UPDATE parent SET a=2;