MDEV-38633: Row events in statement based binlog: optimization possible?

A failing multi-table UPDATE or DELETE marked every target temporary table as not up to date in the binary log, even when nothing had been changed.
Any later statement reading such a table was then forced to use row logging.
Only mark the tables when something was actually changed—that is, when rows were updated/deleted or a non-transactional table was modified.
If nothing changed, set THD::tmp_table_binlog_handled so that mark_tmp_table_as_free_for_reuse() does not mark them either.

Author: pranavktiwari

sql/sql_delete.cc

@@ -1501,10 +1501,19 @@ void multi_delete::abort_result_set()
 
   ***************************************************************************/
 
-  /* the error was handled or nothing deleted and no side effects return */
-  if (error_handled ||
-      (!thd->transaction->stmt.modified_non_trans_table && !deleted))
+  /*
+    Nothing was deleted and there are no side effects: no temporary table
+    was changed, so they all stay up to date in the binary log.
+  */
+  if (!thd->transaction->stmt.modified_non_trans_table && !deleted)
+  {
+    thd->tmp_table_binlog_handled= 1;
     DBUG_VOID_RETURN;
+  }
+  /* The error was already handled */
+  if (error_handled)
+    goto end;
+
 
   /* Something already deleted so we have to invalidate cache */
   if (deleted)
@@ -1551,6 +1560,7 @@ void multi_delete::abort_result_set()
                                transactional_tables, FALSE, FALSE, errcode);
     }
   }
+end:
   /*
     Mark all temporay tables as not completely binlogged
     All future usage of these tables will enforce row level logging, which

sql/sql_update.cc

@@ -2564,9 +2564,17 @@ void multi_update::abort_result_set()
 {
   TABLE_LIST *cur_table;
 
-  /* the error was handled or nothing deleted and no side effects return */
-  if (unlikely(error_handled ||
-               (!thd->transaction->stmt.modified_non_trans_table && !updated)))
+  /*
+    Nothing was updated and there are no side effects: no temporary table
+    was changed, so they all stay up to date in the binary log.
+  */
+  if (unlikely(!thd->transaction->stmt.modified_non_trans_table && !updated))
+  {
+    thd->tmp_table_binlog_handled= 1;
+    return;
+  }
+  /* The error was already handled */
+  if (unlikely(error_handled))
     goto end;
 
   /****************************************************************************