Unable to specify s0 when calling dataset.plot_volcano()

[steph-robinson]

alphapeptstats/alphastats/plots/VolcanoPlot.py

Line 31 in 89843be

class VolcanoPlot(PlotUtils):

Would like to test multiple s0 values for volcano plots, but currently the package does not let me specify new s0 values for it here though sam method is allowed. Could this be added in the future?

[steph-robinson]

Thanks for releasing a new version of the package! Things look great. However, I double checked this portion of VolcanoPlot.py and the s0 value is not an input for the function, so it can't be specified when plotting. It does look that s0 is set to 0.05 later on in the code, but could s0 please be added as a variable in the function, too? Thanks for all the work you have put into this!

class VolcanoPlot(PlotUtils):
    def __init__(
        self, dataset, group1, group2, 
        column=None, method=None, 
        labels=None, min_fc=None, 
        alpha=None, draw_line=None, 
        plot=True, perm=100, fdr=0.05,
        color_list=[]
    ):  

[mschwoer]

Hey,
thanks for reaching out.
Do I understand correctly that it suffices to implement this in the backend as you are using AlphaPeptStats as a python library?

best,
Magnus