Skip to content

Commit d098035

Browse files
committed
apply review feedback
1 parent 5a849fd commit d098035

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

libsyclinterface/tests/test_sycl_context_interface.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,8 @@ TEST_P(TestDPCTLContextInterface, ChkGetAtomicMemoryOrderCapabilities)
208208
ASSERT_TRUE(CRef);
209209
EXPECT_NO_FATAL_FAILURE(
210210
arr = DPCTLContext_GetAtomicMemoryOrderCapabilities(CRef, &len));
211-
EXPECT_TRUE(len > 0);
212-
EXPECT_TRUE(arr != nullptr);
211+
ASSERT_TRUE(len > 0);
212+
ASSERT_TRUE(arr != nullptr);
213213
for (size_t i = 0; i < len; ++i) {
214214
EXPECT_TRUE(arr[i] >= DPCTL_MEMORY_ORDER_RELAXED &&
215215
arr[i] <= DPCTL_MEMORY_ORDER_SEQ_CST);
@@ -228,8 +228,8 @@ TEST_P(TestDPCTLContextInterface, ChkGetAtomicFenceOrderCapabilities)
228228
ASSERT_TRUE(CRef);
229229
EXPECT_NO_FATAL_FAILURE(
230230
arr = DPCTLContext_GetAtomicFenceOrderCapabilities(CRef, &len));
231-
EXPECT_TRUE(len > 0);
232-
EXPECT_TRUE(arr != nullptr);
231+
ASSERT_TRUE(len > 0);
232+
ASSERT_TRUE(arr != nullptr);
233233
for (size_t i = 0; i < len; ++i) {
234234
EXPECT_TRUE(arr[i] >= DPCTL_MEMORY_ORDER_RELAXED &&
235235
arr[i] <= DPCTL_MEMORY_ORDER_SEQ_CST);
@@ -248,8 +248,8 @@ TEST_P(TestDPCTLContextInterface, ChkGetAtomicMemoryScopeCapabilities)
248248
ASSERT_TRUE(CRef);
249249
EXPECT_NO_FATAL_FAILURE(
250250
arr = DPCTLContext_GetAtomicMemoryScopeCapabilities(CRef, &len));
251-
EXPECT_TRUE(len > 0);
252-
EXPECT_TRUE(arr != nullptr);
251+
ASSERT_TRUE(len > 0);
252+
ASSERT_TRUE(arr != nullptr);
253253
for (size_t i = 0; i < len; ++i) {
254254
EXPECT_TRUE(arr[i] >= DPCTL_MEMORY_SCOPE_WORK_ITEM &&
255255
arr[i] <= DPCTL_MEMORY_SCOPE_SYSTEM);
@@ -268,8 +268,8 @@ TEST_P(TestDPCTLContextInterface, ChkGetAtomicFenceScopeCapabilities)
268268
ASSERT_TRUE(CRef);
269269
EXPECT_NO_FATAL_FAILURE(
270270
arr = DPCTLContext_GetAtomicFenceScopeCapabilities(CRef, &len));
271-
EXPECT_TRUE(len > 0);
272-
EXPECT_TRUE(arr != nullptr);
271+
ASSERT_TRUE(len > 0);
272+
ASSERT_TRUE(arr != nullptr);
273273
for (size_t i = 0; i < len; ++i) {
274274
EXPECT_TRUE(arr[i] >= DPCTL_MEMORY_SCOPE_WORK_ITEM &&
275275
arr[i] <= DPCTL_MEMORY_SCOPE_SYSTEM);

0 commit comments

Comments
 (0)