Ineluki Key Patch - Calling a Saves.script file should return the number of saves, not return 1 if at least one save file exists

[Mimigris]

As to be compatible with the fangame Harvest Moon - A New Life mentioned in #1367, when an Ineluki script named Saves.script is called, no matter its content, the Player is hardcoded to add to the output list a value stating whether no save exists (value 0), or if at least one save exists (value 1).

While this works in this case, using it in the Player also changes the behaviour of the command Control Variables: MIDI Ticks to be set to output mode: this is completely unneeded as the game already sets that mode on its own through an autorun.script run at the start of the game that EasyRPG already executes, which calls among others a script called MidiTickOutput.script.wav which sets the mode of Control Variables: MIDI Ticks to output.

[Ghabry]

For reference this is the HLEed saves script:

[execute]
Action = MidiTickFunction
Command = output
next=Saves

[Saves]
Action = AddOutPut
Value = X
next=

;by Stephan Fischer

[Mimigris]

I kinda forgot to refer to this script, as ultimately the original game does more than just that (it calls a SaveCount.script first, which in turns executes a SaveCount.dat file and waits for its execution, which in turns replace the X value from the Saves.script document called just after).

This solves my concern, as ultimately the original program does change the mode.

I have another question for accuracy, though: are we sure that we are accurate on the value retrieved?
Our code (game_ineluki.cpp, line 62) implies that the game retrieves the number of save files to put in the value, but our implementation only outputs the value as a binary to know if the save file exists (0 no save, 1 at least one save exists), so what is the expected behaviour?
I can't test it myself in the original program due to antivirus shenanigans flagging SaveCount.dat as malicious, preventing any download or execution of it.

Checking the code of the game is of no help in this case, as after doing the Saves.script call, the value retrieved is only checked to 1) make sure the value retrieved is in the 0~15 range, otherwise the game retries to get the value until it is in the correct range and 2) if it is 0, no continue option is displayed on the custom title screen, and if it is not 0, it is displayed, which means whether the value is 1 or another value between 2 and 15 causes no gameplay difference.

[Mimigris]

According to KotatsuAkira:

This program in HM-ANL is the same as in any other keypatch-game that makes use of AEP-features (for whatever reason, the HM-ANL I have flying around here also references ExitGame.exe but it's missing).
[SaveCount.dat] (20480)
   CRC32: 088BD301
   CRC64: D77D656C612ABFCD
  SHA256: 25ca7f50898286dbef2a8251de45c4e3b525b8c5b5bee190b82a7c4fda350732
    SHA1: c5f7fb444fecd33ae05ad490211d0373a6c692e2
BLAKE2sp: eb7a5ce2231ae022468b96f550572391fc0b3f0ef1bbdd3bb1a23274b1da8d80
   XXH64: 7ABC6E283450859F

SaveCount creates Sound\Saves.script.wav which outputs a value depending on, as far as I interpret it, files with ext lsd (not Save%.2d.lsd) in the execution-path.

Meaning that the script should indeed return the number of save files and not just return 1 if at least one save file exists.