ICCS Handover review

[Mandresy-code]

Error when launching task 3 :

Traceback (most recent call last): File "/home/surface10/mrasolon/SPIN_review/main.py", line 215, in <module> forcing.write(varlist, resultpath, IDx) File "/home/surface10/mrasolon/SPIN_review/Tools/forcing.py", line 158, in write ncout = Dataset(resultpath + "forcing_regular_" + str(year) + ".nc", "w") TypeError: unsupported operand type(s) for +: 'PosixPath' and 'str'.

Tools/forcing.py needs modification :
Replace : ncout = Dataset(resultpath + "forcing_compressed_" + str(year) + ".nc", "w")
with ncout = Dataset(str(resultpath / f"forcing_compressed_{year}.nc"), "w")

[Mandresy-code]

Every ncout= occurences in the file above should be reformatted as above.

[Mandresy-code]

In config.py, parallel=False is the mode that works. For parallel=True, the last part of Tools/ml.py (Threadpool Execution). does not work anymore.

[ma595]

Hi @Mandresy-code, I think this arose because we ignored step 3 completely. Sounds like the parallel implementation no longer supports task 3?

Note that I updated the parallelism to be Process based (it offers significant improvements).

[Mandresy-code]

In main.py, if sel_most_PFT_sites and not old_cluster: (l.123) is incorrect logic. The lines should be :
if sel_most_PFT_sites and old_cluster: raise ValueError( "sel_most_PFT_sites and old_cluster cannot be set to True at the same time" )

[ma595]

I agree, this should be changed.