More unit testsfor pii - #48
Conversation
|
Welcome, @BabuBahir, and thanks for your first pull request to agent-postmortem. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
d812838 to
6bdd7f3
Compare
|
This is a genuinely good contribution @BabuBahir, thank you. You found the bug yourself while writing tests, traced it to the right cause, and then shipped the fix with both boundary assertions rather than just the one. The The All checks green. Merging, and this closes #47 as well. A star on the repo is appreciated if you enjoyed it, and there are plenty more open issues, including some harder ones now if you want a bigger bite. |
|
Merged, @BabuBahir. Thank you for taking the time. Contributions like this are what keep agent-postmortem moving. A star on the repo would mean a lot if this project is useful to you. Happy to see more from you whenever you have the time. |
What & why
Add more tests too test over-redacting PII redactEmails and redactPhones . As PII information is sensitive so better to over redact than under redact.
Changes
Add tests. Improvised Phone Number regex
Checklist
Closes #123)Resolves #/issues/19
Fixes #/issues/47