test: expand PII redaction coverage - #23
Closed
slegarraga wants to merge 2 commits into
Closed
Conversation
Contributor
|
Closing this one. The author is no longer active on these repos, so it cannot be iterated on, and @BabuBahir has been building a fuller version of this same test file on #19 that also documents two real over-match cases and surfaced a genuine bug (#47). Nothing wrong with the code here, it is just better to land the more complete version in one go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locks down current redaction behavior beyond the single happy path.
ext 12attached to a phone is redacted together, and a long non-phone digit run is conservatively redacted.Verified with Vitest, ESLint, and TypeScript.
Closes #19